From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 58CB442EF5C for ; Mon, 29 Jun 2020 15:50:02 +0300 (MSK) References: <20200629112319.154909-1-gorcunov@gmail.com> From: Oleg Babin Message-ID: <34d2d32a-eb7e-a6a4-d2c8-57448563f02b@tarantool.org> Date: Mon, 29 Jun 2020 15:50:00 +0300 MIME-Version: 1.0 In-Reply-To: <20200629112319.154909-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH 0/3] log: allow json formatter in boottime logger List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Cc: yaroslav.dynnikov@gmail.com Hi! Thanks for your patch. Looks good but I want to clarify one thing: ``` tarantool> log.cfg{log = 'syslog', format='json'} --- ... ``` It works fine but seems such command should throw an error: "json can't be used with syslog logger", isn't it? It happened because "ffi.C.log_type()" returns "0" -- boot-time logger. On 29/06/2020 14:23, Cyrill Gorcunov wrote: > For some reason we've disabled usage of json formatter in early > logging since the commit 098324556. Lets allow it back. > > issue https://github.com/tarantool/tarantool/issues/5121 > branch gorcunov/gh-5121-logger-boot-json > > Cyrill Gorcunov (3): > core/say: allow to use json in boot logger > lua/log: allow to use json formatter early > test: app-tap/logger -- test json in boottime logger > > src/lib/core/say.c | 7 ++----- > src/lua/log.lua | 6 ++---- > test/app-tap/logger.test.lua | 8 +++++--- > 3 files changed, 9 insertions(+), 12 deletions(-) >