From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6FE2D6EC56; Thu, 18 Mar 2021 23:54:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6FE2D6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616100855; bh=zRwToher7iKnl/t9cSosdJHWAHlGJJaassOSM+jsGu4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pPv3k4fo+bu15VHYKBvobcnWU1yQPu+3GEtHTAGcquY8avhv4kwzw5OJLt7BJIRSP ViuryuTN4NU6zEg5/Cs0Ijr3b76mNeEgXB0fXbPAB9buWpUrHZ/EcSQHxFnjXnmSaC LG3tcCgw/S8VzcrIRc9CDRywm6W4uFdUbl3RTVHg= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CFD016EC56 for ; Thu, 18 Mar 2021 23:54:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CFD016EC56 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lMzen-0006Rz-GN; Thu, 18 Mar 2021 23:54:13 +0300 To: Cyrill Gorcunov References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> Message-ID: <34718073-d3ec-87fb-3d75-302acca3484f@tarantool.org> Date: Thu, 18 Mar 2021 21:54:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96485A7A9FC131893DA79D6515A0F039B56A6ED78E402E90C182A05F538085040D381121E38E5D2425722FBC620154C1FACD99E322716F83549BAC086A5B4E5BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376602C647E39EFA3A8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496F3330D996F7E53D9AB3B8BA7FECC13168A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390BCC82C2C62A6D1117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249C94F115956DE4A7A089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CEF3171DE0EC007BF43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148F6B16E133A9586FB82623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BD52826C51A2876ABDCE6BDE3DAAA32CE X-C1DE0DAB: 0D63561A33F958A50BE9A62D477290B693F85A41A6F4037B9A87C0197EFD833FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCFB740EFFCF4D14C3407277385F9289FC32F2B49EF432D00DF3B06508623149F691D7E09C32AA3244CA3B129711DD83C9D345B4C1EED32D2AC69B6CAE0477E908D8D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKyJYJ15DtJLrWx0bcTKHA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DB74DF930741B97069B0212CC486F70F3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: Mons Anderson , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 18.03.2021 21:45, Cyrill Gorcunov wrote: > On Thu, Mar 18, 2021 at 09:36:33PM +0100, Vladislav Shpilevoy wrote: >>>> b) If replicas are not connected and timeout is >>>> expired we kick the cleanup fiber; >>> >>> I mean this. >> >> Then it should have 'replication_' prefix, not 'wal_'. Because >> it is ignored if replicas connect before the timeout expires. > > Replication is one of the reason while main gamer is "wal" > here. In the series I sent recently I named it "wal_cleanup_delay". > In future we might introduce some topology detector as you've > been suggesting and better to not stick to "replication" > prefix I think. The thing you said is just another argument for it having 'replication' prefix. Because topology also is not about WAL. WAL is just a container, it is not a gamer. The thing you fix here is GC, which is manipulated by the replication. The replication forces all the decisions. If the option owner would be WAL, then it should have worked regardless of what is the topology. I.e. keep the logs for the entire timeout even if all is connected. But it is vice versa - the decision when to drop the logs is made by the replication. And it is the replication who gives the command "now you can delete the old logs". If you want wal prefix so bad, at least it should state that this is not the exact timeout. It is a max timeout, which may end much earlier due to any reason: out of disk space, full replication sync.