From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 085126EC5F; Wed, 21 Apr 2021 01:30:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 085126EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618957814; bh=Px6kQH0cYNbIRjorP6w13NulUH9Hx7XOT4miffotFlE=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gIijxG+sUey6T8oCMN84FKe3NTz+ZoV9g1hrJeebCRZm2GmxNRsGGxnhRgFpgTcG4 Z7IqG+0hPslyPLRw3Mlwv6maoJmxjMGM0DrmJVvcKU3f/tB0zBpyCuFxkHJCiHffsg bs5cAtSPQxSt6n2RwjjS5v6rYO6ldRmgoD9TOeFY= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 635EB6EC5F for ; Wed, 21 Apr 2021 01:30:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 635EB6EC5F Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1lYysl-0002Zi-MM; Wed, 21 Apr 2021 01:30:12 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <3374fc86-12fe-0d9c-4b50-d3535edd9be7@tarantool.org> Date: Wed, 21 Apr 2021 00:30:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D5E28B957962BB550182A05F5380850403FBC34570722AA16308BC8ABFD41144B8DE7ADD56CC63BBE225C0DC8B83DC503 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C2758D7B951FF54D8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2BC13AA39D3DD44F61B09292D0B9C040106708AB62ED68B8ED2E47CDBA5A96583C09775C1D3CA48CFA12191B5F2BB8629117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7E4CD18687D5AE3809FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7545E73099E9BA173D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C08790B1EA855AEA32CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD4A55790139E197E6A76F59BC18584746 X-C1DE0DAB: 0D63561A33F958A502AB7E087F67E57E936277912BE829D9D92FFD42EA589D24D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D7D5115130EFC824375821B2E79515792D50A696E0C9041D2E21A9A6AE483ED333211EDB32B0BCED1D7E09C32AA3244C6ADA9DBAD636E1145E1EB2FD7145E3CD853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlPRl29Bx4WEnTDZQ9GS5Jg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA311057E2E3338F93D151BF1715C6A71306A66967BCE13AB6E3CC07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 00/12] raft: introduce manual elections and fix a bug with re-applying rolled back transactions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" I pushed my fixes to this branch: sp/gh-5445-election-fixes-review as separate commits among your commits. It does not mean the patch is perfect for push, we still have known issues with absence of tests, and some moments we still need to fix such as: - Limbo ownership should not change automatically. This is the only way to make it more or less stable; - The NOP filter should work regardless of election mode. Otherwise we still have 5445 issue when it is off; - There are no tests for the NOP filter not working for election off; for a few places in box.cc in box.ctl.promote(); for why in the NOP filter we must use txn origin ID instead of applier instance ID. This might lead to data loss if we did something wrong. My commits are marked as [tosquash]. For the problems above I will create tickets if the patch is pushed as in the branch sp/gh-5445-election-fixes-review.