From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5EBB1469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 14:30:45 +0300 (MSK)
References: <20200605140125.25329-1-sergepetrenko@tarantool.org>
 <20200608112213.hf4fjwwikct74qab@tkn_work_nb>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <3373c95d-5653-9a7c-e6f3-cc46594a0e57@tarantool.org>
Date: Mon, 8 Jun 2020 14:30:43 +0300
MIME-Version: 1.0
In-Reply-To: <20200608112213.hf4fjwwikct74qab@tkn_work_nb>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] decimal: fix build with GCC 10
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


08.06.2020 14:22, Alexander Turenko пишет:
> The patch itself is okay.
>
> On Fri, Jun 05, 2020 at 05:01:25PM +0300, Serge Petrenko wrote:
>> GCC 10 produces the following error:
>> cc1: warning: function may return address of local variable [-Wreturn-local-addr]
>>
>> Fix it.
> It would be good to mention whether it is a real problem or
> false-positive. (The patch is already pushed, so this comment is just
> for information.)


It's a false-positive. The return value  is  only  used to test `dec != 
NULL`.

`dec == NULL` means an error.So, no UB here.

I guess no need for a changelog entry then.

>
> As I see, we actually return a data on the stack before the patch, so it
> worth to mention the bugfix in the release notes. Kirill, can you add
> this?
>
> @ChangeLog
>
> - Fix use-after-scope when converting a decimal number to int64_t or
>    uint64_t that may lead to undefined behaviour in tuple comparators and
>    so in behaviour of space indices (part of gh-4966).
>
> (Serge, correct me if I'm wrong here.
>
> BTW, are those hints pesisted for vinyl? Can we get wrong results even
> after upgrade?
>
> WBR, Alexander Turenko.

-- 
Serge Petrenko