From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3F39C2B797 for ; Fri, 29 Mar 2019 17:06:12 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OqWOeIZ0Lnk8 for ; Fri, 29 Mar 2019 17:06:12 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 99E192B795 for ; Fri, 29 Mar 2019 17:06:11 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v9 4/7] lua: remove exceptions from function luaL_tofield() References: <20190328175410.GC4864@tarantool.org> <58e2a19a-e6ce-bfaf-d926-c216ae83f197@tarantool.org> <20190328195632.GA3204@tarantool.org> From: Vladislav Shpilevoy Message-ID: <332f5fc3-cf94-ce94-cc5e-e869c3e0117c@tarantool.org> Date: Sat, 30 Mar 2019 00:06:08 +0300 MIME-Version: 1.0 In-Reply-To: <20190328195632.GA3204@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Mergen Imeev Cc: tarantool-patches@freelists.org Thanks for the fixes! I've failed to find a simpler solution, so I kept is_value_returned. But I refactored inspect_table() a bit taking into account that if is_value_returned can be set only together with is_serialize_used. Also I wrote more descriptive comments. See on the branch. I squashed all our fixes into your main commit.