From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B47CE6EC41; Sun, 8 Aug 2021 17:35:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B47CE6EC41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628433308; bh=2LHCeJPURN7Vakr0IXyrk4E+0EuqgDiUSj++ahqoX00=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KLVdiEsFBLdDlH6Lb1rhWgZK8lEdgpen+17VtXTzUNrzr8d5lMli8NNl60Piqq6o3 M52Ns0hOSl565ebHoZ8B6v6FOpwIfIunh0I6BsMwpgVNwD75f89mqTj4D0Nz6eWeTY lomsLNb7T75qlTwMZyUCQ4parbn1RhmyWDxdFUEo= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 512D06EC41 for ; Sun, 8 Aug 2021 17:34:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 512D06EC41 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1mCjsx-0000W8-H1; Sun, 08 Aug 2021 17:34:43 +0300 To: Safin Timur , olegrok@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <3307ec8b-f72f-a33e-9ddb-37d7fd300bd5@tarantool.org> Date: Sun, 8 Aug 2021 17:34:43 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F6525B29142351271182A05F538085040D6D5340EC5942408C6B57A6D59AD03C9A2442A5DF96B4A3CD73E73D7ACEA930B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE770FEBAE29342FA8FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E92E38DA2D50EB18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8514766A227BCE4F1D8996F32A5BAF0A5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC7335A8D70E1B36BF3AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F790063792ACDD2839142C15D81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B5E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A50F93EC07687010178E9FDA9405B387E9E9233BFB62529BB3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75AF0B556A5A327A45410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34128DEC38EFF4BE5A6AC5BD33F8FDAF4A6952A4C742446691C45C146228541EA7572A01EF7F1A271C1D7E09C32AA3244C5A0ECD9EAF3CBE8DA83D090E0D384FC033C9DC155518937FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMTMPlNJj3SgrGyj2RcNi7g== X-Mailru-Sender: 6C3E74F07C41AE94D32402E5012278FAF845936906850D5BFEB1C7F6C3F7AA3FAD5F2BC29BC1F62207784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 1/9] build: add Christian Hansen c-dt to the build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 05.08.2021 11:55, Safin Timur wrote: > Hello Vlad! > > On 05.08.2021 2:58, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch! >> >> On 02.08.2021 02:40, Timur Safin via Tarantool-patches wrote: >>> * Integrated chansen/c-dt parser as 3rd party module to the >>>    Tarantool cmake build process. >>> * Points to tsafin/c-dt instead iof original chansen/c-dt to >>>    have easier build integration, because there is additional >>>    commit which integrated cmake support >> >> As I said in the previous review, it points at >> https://github.com/tarantool/c-dt.git, not at tsafin/c-dt. Why >> do you keep saying the contrary? Look: >> >>     url = https://github.com/tarantool/c-dt.git >> >> It is 'tarantool', not 'tsafin' here. > > Yes, that was oversight, due to several restarts of rebase session > (I guess due to mess generated with combination of --autosquash and git rerere) > Now finally applied to this commit in branch as commit #4b90de3bb21b9f28bc7c1f8e851d4c95f1b0f191. > >> >> Also, like on the previous review, when I call 'make' and do >> 'git status', I see: >> >>     Changes not staged for commit: >>       (use "git add ..." to update what will be committed) >>       (use "git restore ..." to discard changes in working directory) >>       (commit or discard the untracked or modified content in submodules) >>         modified:   third_party/c-dt (modified content, untracked content) >> >> You still didn't fix it. Please, do. >> > > That was not a problem for me, due to the fact I _always_ use out-of-source build, and all artifacts generated separately under ${CMAKE_CURRENT_BINARY_DIR}/third_party/c-dt/, and such artifacts > inside of source tree problem observed only when you do (not very idiomatic) in-source build. cmake generated Makefile overwrite original c-dt Makefile. > > [While we are here, could you please remind me why we recommend to use in-source build in our documentation? > And not prefer the recommended and used by majority of industry for what matter out-of-source build?] No idea. I personally use in-source build because I have just used to it. > We could rather may not influence how and where artifacts will be generated from inside of our own c-dt/CMakeLists.txt, we should rather modify the way how it get used, like, not include it via simple add_subdirectory(which is exactly defining this ${CMAKE_CURRENT_BINARY_DIR}/third_party/c-dt, which would be equal to ${CMAKE_CURRENT_SOURCE_DIR}/third_party/c-dt for in-source build, but rather use some ExternalProject_Add() techniques, which allows to redefine generated and binary files localtion. Let me check what is the easiest way here... I am not a cmake master, so I don't know a correct way to fix it. But I don't understand why do you need Makefile in c-dt at all if it works via cmake anyway and 100% of that Makefile is simply overwritten. It is not used. If a file is not used and is overwritten anyway, why not drop it from the repository? Also I see Untracked files: (use "git add ..." to include in what will be committed) libcdt.a You need to update gitignore so as there is no the warning.