From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 803176EC5F; Fri, 30 Apr 2021 23:46:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 803176EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619815570; bh=sO4rNbPUw/ZA0oXf8ntjwpI/zqvZI46GQF6Kp/nHhTg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fQCx9Vpd6As7PeHEif/nkXjyz91quzkwijKs5lvSSxaCgQEm7WcY1yiEP4sCMbwnP KDWVI/kNkvkuEwMY7KyhKJm3Qwoac/d3SKP7CZlpwdLKvphQNS/z6Atv3z0zwjb0lK 4mRUxDTkU2KsIWMKObVoBTg03X6x/3JlEM9UN4s0= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E60676EC5F for ; Fri, 30 Apr 2021 23:45:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E60676EC5F Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1lca1F-0004pN-8i; Fri, 30 Apr 2021 23:45:49 +0300 To: Cyrill Gorcunov , tml Cc: Mons Anderson References: <20210430153940.121271-1-gorcunov@gmail.com> <20210430153940.121271-2-gorcunov@gmail.com> Message-ID: <3289b448-233e-efa6-2e62-79c5eedee62b@tarantool.org> Date: Fri, 30 Apr 2021 22:45:48 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210430153940.121271-2-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0BB6090B4F8997C21AA3492AFA30115D5182A05F5380850404C6F0127A43880C94F9348722E3BC0EE15179D460CC9DF1F5BCFBCE3F3E825D1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE4525FFB91B9BBCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371111040D1ED495018638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B23867DB7DF1579D18B2E638397819D8902AAFC1FEE5B068F7D2E47CDBA5A96583C09775C1D3CA48CFA367EA73E0D98AAD117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE72B26B6EDD975AFD79FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE75B777574BC76166D7B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB28585415E75ADA91C9461EB66F04EBFB3661434B16C20AC78D18283394535A9E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C9783108A89A4B5509FEFCAC1B55117025DB7A X-C1DE0DAB: 0D63561A33F958A53032AB16905BAF7D71306EE322103F71B15138517FA22759D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34753B45383CEFF20472245B557C733DBBBB801579FE3081C41B70B088548933EFA25D3DA65FE0125F1D7E09C32AA3244C1348FFDD2ECA75F66780DEDA70BDE8F639C99C45E8D137E9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9hvEon6tehMLirauCJ760w== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110C7DC377089BD06F09BBC997398D25C24B8B74781E454743307784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC v3 1/3] xrow: allow to pass timestamp via xrow_encode_vclock_timed helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! I am not sure it is needed though. You can simply assign tm after encode(). Grep `xrow_encode_vclock()` to see examples where sync is assigned after encode, it looks fine. Too many changes just for a single usage.