From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C0A254765E0 for ; Tue, 22 Dec 2020 19:40:57 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <3250fe4a-8b21-bf49-1747-452882a73721@tarantool.org> Date: Tue, 22 Dec 2020 17:40:56 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Tarantool-patches] [PATCH v3 2/2] base64: improve decoder performance List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Nikiforov , tarantool-patches@dev.tarantool.org >>> diff --git a/test/unit/base64.c b/test/unit/base64.c >>> index ada497adf..76db7d782 100644 >>> --- a/test/unit/base64.c >>> +++ b/test/unit/base64.c >>> @@ -34,6 +34,11 @@ base64_test(const char *str, int options, const char *no_symbols, >>>       free(base64_buf); >>>       free(strbuf); >>>   +    const char *in = "sIIpHw=="; >>> +    int in_len = strlen(in); >>> +    rc = base64_decode(in, in_len, NULL, 0); >>> +    is(rc, 0, "no space in out buffer"); >> >>  From the .result file it is clear this test is done multiple >> times. And it does not depend on base64_test() arguments. So why >> do you run exactly the same test again and again? Maybe move it >> to a separate test function which is run only once? > > Ok, I will do this if there will be another patch revision. > You are, however, reviewing your own code - I have just used your patch from earlier review iteration (17 Dec 2020 00:22:08 +0100) I used it as an example. You don't need to blindly merge everything I post here. Because the patch is yours, not mine. And I may be wrong quite often.