From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 2/4] iproto: fire on_disconnect right after disconnect References: <0fd1142f244d285cf74a8e2045f182ade4694020.1544197465.git.v.shpilevoy@tarantool.org> <20181207173730.GD840@chai> From: Vladislav Shpilevoy Message-ID: <322dad9a-cb57-f896-19c3-2350b4de3b6e@tarantool.org> Date: Tue, 11 Dec 2018 15:55:06 +0300 MIME-Version: 1.0 In-Reply-To: <20181207173730.GD840@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: On 07/12/2018 20:37, Konstantin Osipov wrote: > * Vladislav Shpilevoy [18/12/07 18:48]: >> Before the patch on_disconnect triggers were called >> only after last outstanding request had finished. It >> was enough for most goals. But after box.session.push >> was implemented, it appeared that it is impossible to >> return an error from push() if a connection is closed. >> >> Tx session just does not know that a connection is >> already closed. The patch splits destroy and >> disconnect phases of an iproto connection lifecycle. >> Disconnect calls on_disconnect triggers and resets >> iproto socket fd. Destroy frees resources. > > OK to push. > >> Needed for #3859 > > Pushed to 2.1 and 1.10.