From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66A2B445320 for ; Fri, 24 Jul 2020 01:10:45 +0300 (MSK) References: <20200723122942.196011-1-gorcunov@gmail.com> <20200723122942.196011-3-gorcunov@gmail.com> From: Vladislav Shpilevoy Message-ID: <3200ccb1-1c97-54be-a034-ffae0abf09cc@tarantool.org> Date: Fri, 24 Jul 2020 00:10:43 +0200 MIME-Version: 1.0 In-Reply-To: <20200723122942.196011-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2 2/7] wal: bind asynchronous write completion to an entry List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thanks for the patch! See 5 comments below. On 23.07.2020 14:29, Cyrill Gorcunov wrote: > In commit 77ba0e3504464131fe81c672d508d0275be2173a we've redesigned > wal journal operations such that asynchronous write completion > is a signle instance per journal. 1. signle -> single > It turned out that such simplification is too tight and doesn't > allow us to pass entries into the journal with custom completions. > > Thus lets allow back such ability. We will need it to be able > to write "confirm" records into wal directly without touching > trasactions code at all. 2. trasactions -> transactions 3. Please, add 'Part of #5129' to the commits related to the issue. > Signed-off-by: Cyrill Gorcunov > --- > diff --git a/src/box/box.cc b/src/box/box.cc > index 83eef5d98..7d61f2ed2 100644 > --- a/src/box/box.cc > +++ b/src/box/box.cc > @@ -2628,7 +2630,7 @@ box_cfg_xc(void) > } > > struct journal bootstrap_journal; > - journal_create(&bootstrap_journal, NULL, txn_complete_async, > + journal_create(&bootstrap_journal, bootstrap_journal_write, 4. Please, leave the sync write() NULL. I did it intentionally so as it would early fail if bootstrap will call blocking write anywhere. > bootstrap_journal_write); > journal_set(&bootstrap_journal); > auto bootstrap_journal_guard = make_scoped_guard([] { > diff --git a/src/box/journal.c b/src/box/journal.c > index f1e89aaa2..fb81acb39 100644 > --- a/src/box/journal.c > +++ b/src/box/journal.c > @@ -36,6 +36,7 @@ struct journal *current_journal = NULL; > > struct journal_entry * > journal_entry_new(size_t n_rows, struct region *region, > + void (*write_async_cb)(struct journal_entry *entry), 5.I think it would be better to move the callback definition to a typedef. Otherwise it looks too bulky and too many places to change, if will need to change the signature. > void *complete_data) > { > struct journal_entry *entry;