From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AE62E5CE1A1; Tue, 29 Aug 2023 18:11:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AE62E5CE1A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693321866; bh=XoIKwhM3bVYfiu8p+DjI4t8a3DJ1XQNgr/WS7ck4Hu8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VxHujjuwt3PlnG1V2c0VYTWLrnsOUMOxg/KUOYgNGsZ6teO6sNfl7AlVTA0Q2g/+h 2nHr8dqz6z86A2vW4PdCBPtgC6WnhrAiVnk/gPRXVrAdzo10BU9F4U/LFDSdOgF9WR 3Dtxt0QVCZtN2iMeoilfakvn/t1CmenBWEMPGV/o= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 80B015CE1A1 for ; Tue, 29 Aug 2023 18:11:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 80B015CE1A1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qb0My-0006Gd-QA; Tue, 29 Aug 2023 18:11:05 +0300 Message-ID: <31d78cfd-f465-05ac-e94b-7c48b36439ed@tarantool.org> Date: Tue, 29 Aug 2023 18:11:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com References: <8b2d744f68eb138c2b2c37e1ac851181e303b485.1693305720.git.sergeyb@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9AE2E1BB6058F4E369B6B02B1FF0BFBA6A449FFCCAAF5D304182A05F538085040809447091A257F5EAAB6D332FA0003A3CF6E02018251FEB0FE3892214652E3B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7978947DCA0D4215FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063798FF8892961A0B3C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88628BCD820A61FFD1BF7C8BEA4DC2C60117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCCFF48519C1EE79E1A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A8DADCFA31BDB70175ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A59159671653FCB709A6F31359FB75449E0E3922DAE0A13948F87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340FE9920E7E3E5C62616BD7BE3F16CD85760C915ED659B7AEE8C33BCA0120452ECBC83243EEFF545D1D7E09C32AA3244C5C5D254CBAF9D4585E1DE420AEE6E1A7A90944CA99CF22E3BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojA5xtch+oMC5L6KtBw4Ewtg== X-DA7885C5: E154F992496753AF3FD0CA3BD371C294F27D75B715D91AC7B57233FB790AB54D262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BA0712FF69E977DC1B9DBCBD25D46C75FDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, On 8/29/23 17:43, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the updates! > LGTM, after fixing several minor comments below. > > On 29.08.23, Sergey Bronnikov wrote: > Part of tarantool/tarantool#8825 > --- > > PR:https://github.com/tarantool/tarantool/pull/9054 > Branch:https://github.com/tarantool/luajit/tree/ligurio/lj-1054-incorrect-pc-value-predict_next > Related issue: > *https://github.com/LuaJIT/LuaJIT/issues/1054 > > src/lj_parse.c | 4 +++- > ...incorrect-pc-value-in-predict_next.test.lua | 18 ++++++++++++++++++ > I suggest to use predict-next instead in filename and testname to be > consistent with other tests. Fixed: --- a/test/tarantool-tests/lj-1054-fix-incorrect-pc-value-in-predict_next.test.lua +++ b/test/tarantool-tests/lj-1054-fix-incorrect-pc-value-in-predict_next.test.lua @@ -1,12 +1,12 @@  local tap = require('tap') -local test = tap.test('lj-1054-incorrect-pc-value-in-predict_next') +local test = tap.test('lj-1054-fix-incorrect-pc-value-in-predict_next')  test:plan(3) >>>> +-- See alsohttps://github.com/LuaJIT/LuaJIT/issues/528 > Nit: Missed dot at the end of the sentence. > Typo: s/528/1054./ > > >  -- The test demonstrates a problem with out-of-boundary  -- access to a stack. The problem can be easily observed  -- on execution the sample by LuaJIT by ASAN, sanitizer  -- reports a heap-based buffer overflow. --- See also https://github.com/LuaJIT/LuaJIT/issues/528 +-- See also https://github.com/LuaJIT/LuaJIT/issues/1054.  local res_f = loadstring([[  a, b, c = 1, 2, 3