From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7E2376EC55; Thu, 29 Jul 2021 01:49:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E2376EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627512559; bh=IHGWqEA8jWHb1Glh7gDK0NEjfiCOlyMmWLfaXhpjmEY=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JdsRywkJ5QXGtrVFsRtPE9RTIBjz0pkemZCaOkPvuL6Ik+9CkxvHEouAMKKktLpp8 EAFm/U3NMJ2DQpcPKhzu52+duYVEk+waX1STZwbM8mswNJBVoremBkMIw1BlAGOx7q 7UUhtjX3ax+ifJzOVsnzResgs1YEbKcIIX2cPFSI= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E92326EC55 for ; Thu, 29 Jul 2021 01:49:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E92326EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m8sMY-0004SS-44; Thu, 29 Jul 2021 01:49:18 +0300 To: Vladimir Davydov , tarantool-patches@dev.tarantool.org References: Message-ID: <3180fd58-9239-6007-e8ce-2d779defb17d@tarantool.org> Date: Thu, 29 Jul 2021 00:49:17 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F538085040744149539410089584312D35E1B65BD3109855BDBC1AAFF8A67868AA3B7B9A81 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371AB0416A4896C0B38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D882E8A3F3E77A9941095B72402AF0501C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505450CC5E296C4E36330DCA88879ADCA8C X-C1DE0DAB: 0D63561A33F958A5209D4F8B8730B74AEEF2C374DC0595B1B65DBAA05816C37DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3452F7993FB7281BFD9CA99236F224EFA873E9400B53A46F9E913A7227827DA55A647664C8B7D6DC6C1D7E09C32AA3244C2DB83865A7E60D6D45F21A87B61C65E17101BF96129E4011729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawGPDYfFWKVS0A== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D2073E99E91E6D65C486F492D180C16063841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 01/20] net.box: fix console connection breakage when request is discarded X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! The commit is different from what I see on the branch. Please, try to keep the email thread up to date. Or do you prefer the github PRs now? Here and in other emails I will use the commits I see on the branch. > diff --git a/test/box/net.box_discard_console_request.result b/test/box/net.box_discard_console_request.result > new file mode 100644 > index 000000000..e8da50a2f > --- /dev/null > +++ b/test/box/net.box_discard_console_request.result For bug tests we now use name format `gh-####-your-description`. The other names different from this format are outdated and should not be used as an example. https://github.com/tarantool/tarantool/wiki/Code-review-procedure#testing The rest of the commit LGTM.