From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Subject: Re: [tarantool-patches] [PATCH v3 09/14] wal: a dedicated wal scheduling fiber Date: Thu, 13 Jun 2019 22:36:30 +0300 Message-ID: <3143671.OOzuiaNZFI@home.lan> In-Reply-To: <20190613142452.j63yqr4q53xszo4r@esperanza> References: <64f63cc1cea7a3c632561f36eb043cb386c4e472.1560112747.git.georgy@tarantool.org> <20190613142452.j63yqr4q53xszo4r@esperanza> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1670287.eTyAZ4KMza"; micalg="pgp-sha256"; protocol="application/pgp-signature" To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: --nextPart1670287.eTyAZ4KMza Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, June 13, 2019 5:24:52 PM MSK Vladimir Davydov wrote: > On Sun, Jun 09, 2019 at 11:44:38PM +0300, Georgy Kirichenko wrote: > > This adds an extra ctxsw to the relatively hot WAL writer wakeup path so > we can't commit it. I assume it's a temporary hack you added so that you > can submit this patches for review. This adds at most only one ctxsw on each wal branch and we could ask Alexander to bench it. > > I understand why you're doing this, but the right way would be removing > yields from on_commit triggers. We need to make vy_log_write yield-free. I'm totally agreed, however, I'm not sure could disable yields for on_commit/ on_rollback right now. --nextPart1670287.eTyAZ4KMza Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAl0Cpb4ACgkQFSyY70x8 X3vSWQgAidpTsOzSDyF77Lu6vM36s8hXbAhqgK207KkTGJ8f3V/VHPjEFY7t5IR/ aeNHi+Rf6Idx4Y3vc2eg+y+b1QMM5QPJaViDtIG2aKA7uSC+W41EfqyK1SqsUCmg LW2i5mtJxbNTDf+zD1OuAC6jyVgpCsVgC2jcNmGFEtSmzC8UEDUh0bq4wHuVYOJY I/XB6p0YGIyPOX3Nx0cPxzdRBnaDdRL5faEjXalCyZ/55zTc3DSOsOdqV2hmEjk2 sBx2KRxOW49thLdP63MqPle3sHcE5ihtDiS0MeoqKFOWalXpWxaJaN7FhTjElgZo KCd4mqX1W8z52rcueafnycoIqQuIgA== =JUuf -----END PGP SIGNATURE----- --nextPart1670287.eTyAZ4KMza--