From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4D3326EC57; Fri, 15 Oct 2021 01:43:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D3326EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634251407; bh=un0lmQy492uIEvhG6QVmsYwAvRGWTUhZ3zZXRROTJ6c=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G62NEOCaRX/gI9S/ztvUzV1F6Y2atW83YMb0vy3R7IUpE/qhSNn4YjzRgyxukI0eY 85/BlLZRgQqCjeflPJXh+2egO9HI30GqC7yDj31LqXGuqcATmXk34vzdK4YCIBkzkr 2F1H5y7yTa9+YfT2ESef8xcSKoQKMF7jy2GZ/opQ= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A2E5B6EC57 for ; Fri, 15 Oct 2021 01:43:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A2E5B6EC57 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mb9RT-0008Td-0Y; Fri, 15 Oct 2021 01:43:15 +0300 Message-ID: <30a2f5e5-ccf8-2103-bc67-ac55264213cd@tarantool.org> Date: Fri, 15 Oct 2021 00:43:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9AE9EF867AE584ADAC10ADC6D58547CF64A6290FE785EBC69182A05F5380850409689058ADB5BB559C8FB527E05F1FAD42B56C72FFAC7A8905DA4A668DCB03ECB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374DF0C582D42FCA168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8365CFF54075A48FDD8CFF3E6B15BD041117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50580647984BABFFB52A92918FC925416F8 X-C1DE0DAB: 0D63561A33F958A57676BEC3C22E7A7A8F237FD3AAF5708B1853C963CF2893C7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3467D08F30473A58425409663243288986B8AC17774FB1C60CC7B241465941BB3236F487D7E56B01401D7E09C32AA3244C759F3D31B81E5EA8FE6EDB16FE17BDF99CA7333006C390A0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZCle+NCKLXGyWmR9UiTROA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D37AA7E21E49BB32C43CC127D84EE064E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 03/21] sql: refactor HEX() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the patch! > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index 7886f5f40..e5d763be1 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -800,6 +800,39 @@ func_greatest_least(struct sql_context *ctx, int argc, struct Mem *argv) > ctx->is_aborted = true; > } > > +/** Implementation of the HEX() function. */ > +static const char hexdigits[] = { > + '0', '1', '2', '3', '4', '5', '6', '7', > + '8', '9', 'A', 'B', 'C', 'D', 'E', 'F' > +}; > + > +static void > +func_hex(struct sql_context *ctx, int argc, struct Mem *argv) > +{ > + assert(argc == 1); > + (void)argc; > + struct Mem *arg = &argv[0]; > + if (mem_is_null(arg)) > + return mem_set_null(ctx->pOut); Isn't pOut already null? I thought it is created as null.