From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 480FB2850D for ; Fri, 22 Feb 2019 10:54:43 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r-Bf4MGIIQmp for ; Fri, 22 Feb 2019 10:54:43 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ED62428504 for ; Fri, 22 Feb 2019 10:54:42 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH 0/3] Concatenation operator type fixes References: From: Vladislav Shpilevoy Message-ID: <30686cfa-f861-683c-8e38-4311e13012f6@tarantool.org> Date: Fri, 22 Feb 2019 18:54:40 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik , Kirill Yukhin LGTM. On 19/02/2019 11:28, Nikita Pettik wrote: > This patch makes concatenation operator follow ANSI rules. > For now, only operands of string-like types (TEXT or BLOB) are > accepted. What is more, fixed resulting type of concatenation: > if both operands are of BLOB type, then the resulting value is of > BLOB value too. > > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3544-fix-randomblob-type > Issue: https://github.com/tarantool/tarantool/issues/3544 > > Nikita Pettik (3): > sql: fix value of mask to map VDBE memory type > sql: allow only string-like arguments for concatenation > sql: fix resulting type for concatenation operator > > src/box/errcode.h | 1 + > src/box/sql/vdbe.c | 59 ++++++++++++++++++++++++++++++++++++++--- > src/box/sql/vdbeInt.h | 9 +++++++ > src/box/sql/vdbeapi.c | 2 +- > test/box/misc.result | 1 + > test/sql-tap/autoinc.test.lua | 12 ++++----- > test/sql-tap/e_select1.test.lua | 4 +-- > test/sql-tap/func.test.lua | 4 +-- > test/sql-tap/sort.test.lua | 6 ++--- > test/sql-tap/tkt2192.test.lua | 4 +-- > test/sql-tap/trigger5.test.lua | 4 +-- > test/sql/types.result | 42 +++++++++++++++++++++++++++++ > test/sql/types.test.lua | 16 +++++++++++ > 13 files changed, 143 insertions(+), 21 deletions(-) > > -- > 2.15.1 > >