From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 912D9441840
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  1 Apr 2020 13:44:22 +0300 (MSK)
References: <1090ea3aa089beee61c44d0e42b3bcf6ea250782.1585171743.git.lvasiliev@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <3037d64f-69fe-86ed-e30c-60e1704bfa69@tarantool.org>
Date: Wed, 1 Apr 2020 13:44:20 +0300
MIME-Version: 1.0
In-Reply-To: <1090ea3aa089beee61c44d0e42b3bcf6ea250782.1585171743.git.lvasiliev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] rocks: forward options to luarocks
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for your patch I have several comments.

On 26/03/2020 01:01, Leonid Vasiliev wrote:
 > From: Leonid <lvasiliev@tarantool.org>
 >
 > https://github.com/tarantool/tarantool/issues/4629
 > 
https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags
 >
 > Corresponding thread 
https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/015143.html
 >
 > @Changelog
Please put branch, issue and changelog under "---". This should not be a 
part of commit message.
 > Chdir has been moved to luarocks.

It's quite important thing to preserve backward compatibility.
How it works now:
```
tarantoolctl rocks make --chdir ../tracing

Warning: variable CFLAGS was not passed in build_variables
mkdir -p doc
tracing scm-1 is now installed in 
/Users/o.babin/Projects/tarantool/.rocks (license: BSD)
```

How it looks on your branch:
```
./src/tarantool ./extra/dist/tarantoolctl rocks make --chdir ../tracing

Error: Invalid argument: unknown flag --chdir. See --help.
```

And I don't see any mentions of this option in "rocks --help". May be I 
do something wrong? But make sure that behaviour of this option was not 
changed. It's quite important for solutions.

---
Oleg Babin