From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A13E86EC5B; Fri, 14 May 2021 13:10:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A13E86EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620987034; bh=XkvainWNOLNnDJWjoFuNQqVs262VFRinWAGpoQJIwdk=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Zz7wR3fxRAmnjzY+aVxP3FqSdw4GroQPMM79s0r7ZeYNwpjMHajj8bVrwfEvxfR1/ ZPH2DM3aYaTHVGtCVQjk3sXJsJ3DR+zIDEJek3fmX92ftx55WgqscBl6aXuoJiQxjO Y9/MyqdD+oN/TrxZDza1U29CVywuQB4ZFktqAyvU= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A531C6EC5B for ; Fri, 14 May 2021 13:10:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A531C6EC5B Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1lhUm7-0003cN-Kx; Fri, 14 May 2021 13:10:32 +0300 Message-Id: <3023B2B8-259B-466D-8218-818D01B0D721@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_2C44BBBF-1293-421F-81B2-524D6CC9A962" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 14 May 2021 13:10:30 +0300 In-Reply-To: <20210513104418.GG3944@tarantool.org> To: Igor Munkin References: <6753245c0309ed77250a6ac41fb7bfd3f82676c2.1620678384.git.imun@tarantool.org> <20210511113115.GD3944@tarantool.org> <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> <20210512215956.GF3944@tarantool.org> <20210513104418.GG3944@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0AAE50420B6EFF6A4E51E23FC86C8E287182A05F538085040D8DA46BE36D12B8611F385DF447603D0E2FCECFE31CD40FC729364708D586881 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E9C30BC00893CB9AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE92FB8C11ED3D88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DB11672AB9BCC7E0E8396BA6247A856F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F1B780A39BCC1DD35D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3568FCE88E0C8489DAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A7EFCB0EB5ACB161EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831AD574680ECDBB72CDABE82F96B12BFBC X-C1DE0DAB: 0D63561A33F958A5999FC49F4076EE76D9C7ADA1FA3D2F242874F5DAF22D9A75D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3442AF01057B6BF9973D644F3F64CAFFAD80C57523B9FE7827C02A497E5B31412CFBDA84A57FFF13611D7E09C32AA3244C7CFFA435C9499AD9C03AD49495D8BF1DF26BFA4C8A6946B8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQW18whK8Tdiwg== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC0666FA939401AA0CACC44943B60E9AB0CDDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_2C44BBBF-1293-421F-81B2-524D6CC9A962 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 13 May 2021, at 13:44, Igor Munkin wrote: >=20 > Sergos, >=20 > On 13.05.21, Sergey Ostanevich wrote: >> Well, this doesn't help me with >>=20 >>> Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 define = being >>> set, we can simply replace all occurrences with LJ_TARGET_OSX. >=20 > OK, as a result of offline discussion I've finally got it (hope you > too). Everything written above relates only to FFI sources that are > touched within this changeset (consider FFI prefix in commit subject). >=20 >>=20 >> alongside with >>=20 >>> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS >=20 > Strictly saying, this commit[1] has not been backported yet. >=20 >>=20 >> because if we apply first then the second will evaluate into >>=20 >> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_OSX >>=20 >> which is always false? >>=20 >> Also there are still operable 32bit apps, including games, so iOS >> still supports 32bits - can this change cause problems? I believe = Mike >> doesn=E2=80=99t care too much, so it can easily slip through. >=20 > As we discussed, 32-bit platforms are not touched in this commit, so > nothing criminal. >=20 > Anyway, I see this is unclear to you, but everything is OK for Sergey. > Do I need to reword this part of commit message or even drop it? Just update the wording All LJ_TARGET_IOS uses in FFI sources are done with LJ_TARGET_ARM64 = define being set, so we can simply replace these occurrences with LJ_TARGET_OSX. And it=E2=80=99s LGTM. Sergos >=20 >>=20 >> Sergos >>=20 >>=20 >>=20 >>> On 13 May 2021, at 00:59, Igor Munkin wrote: >>>=20 >>> Sergos, >>>=20 >>> On 12.05.21, Sergey Ostanevich wrote: >>>> Hi! >>>>=20 >>>> I can=E2=80=99t get this then >>>>=20 >>>> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS >>>=20 >>> There is a verbose comment nearby[1] and the corresponding issue[2]. >>>=20 >>>>=20 >>>> How=E2=80=99s that survived in 2.1 branch? >>>>=20 >>>> regards, >>>> Sergos >>>>=20 >>>>=20 >>>>> On 11 May 2021, at 14:31, Igor Munkin wrote: >>>>>=20 >>>>> Sergey, >>>>>=20 >>>>> Thanks for your review! >>>>>=20 >>>>> On 11.05.21, Sergey Kaplun wrote: >>>>>> Hi, Igor! >>>>>>=20 >>>>>> Thanks for the patch! >>>>>> LGTM! >>>>>=20 >>>>> Added your tag: >>>>> | Reviewed-by: Sergey Kaplun >>>>>=20 >>>>> Also mentioned the issue[1]: >>>>> | Resolves tarantool/tarantool#6066 >>>>>=20 >>>>>>=20 >>>>>> --=20 >>>>>> Best regards, >>>>>> Sergey Kaplun >>>>>=20 >>>>> [1]: https://github.com/tarantool/tarantool/issues/6066 >>>>>=20 >>>>> --=20 >>>>> Best regards, >>>>> IM >>>>=20 >>>=20 >>> [1]: = https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119 >>> [2]: https://github.com/LuaJIT/LuaJIT/issues/668 >>>=20 >>> --=20 >>> Best regards, >>> IM >>=20 >=20 > [1]: https://github.com/LuaJIT/LuaJIT/commit/7877369 = >=20 > --=20 > Best regards, > IM --Apple-Mail=_2C44BBBF-1293-421F-81B2-524D6CC9A962 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 13 May 2021, at 13:44, Igor Munkin <imun@tarantool.org> = wrote:

Sergos,

On 13.05.21, Sergey Ostanevich wrote:
Well, = this doesn't help me with

Since all LJ_TARGET_IOS usage is done with = LJ_TARGET_ARM64 define being
set, we can simply replace = all occurrences with LJ_TARGET_OSX.

OK, as a result of offline discussion I've finally got it = (hope you
too). = Everything written above relates only to FFI sources that are
touched = within this changeset (consider FFI prefix in commit subject).


alongside with

src/lj_prng.c:112:#if LJ_TARGET_OSX && = !LJ_TARGET_IOS

Strictly = saying, this commit[1] has not been backported yet.


because if we apply first then the second will evaluate = into

src/lj_prng.c:112:#if LJ_TARGET_OSX = && !LJ_TARGET_OSX

which is always = false?

Also there are still operable 32bit = apps, including games, so iOS
still supports 32bits - can = this change cause problems? I believe Mike
doesn=E2=80=99t = care too much, so it can easily slip through.

As we discussed, 32-bit platforms are not touched in this = commit, so
nothing = criminal.

Anyway, I see = this is unclear to you, but everything is OK for Sergey.
Do I need to = reword this part of commit message or even drop it?

Just = update the wording

All LJ_TARGET_IOS uses = in FFI sources are done with LJ_TARGET_ARM64 define being
set, so we can simply = replace these occurrences with LJ_TARGET_OSX.

And it=E2=80=99s LGTM.

Sergos


Sergos


On 13 May 2021, at 00:59, Igor Munkin <imun@tarantool.org> = wrote:

Sergos,

On 12.05.21, Sergey Ostanevich wrote:
Hi!

I can=E2=80=99t= get this then

src/lj_prng.c:112:#if = LJ_TARGET_OSX && !LJ_TARGET_IOS

There is a verbose comment nearby[1] and the corresponding = issue[2].


How=E2=80=99s that survived in 2.1 branch?

regards,
Sergos


On 11 May = 2021, at 14:31, Igor Munkin <imun@tarantool.org> wrote:

Sergey,

Thanks for your = review!

On 11.05.21, Sergey Kaplun = wrote:
Hi, Igor!

Thanks for the patch!
LGTM!

Added your tag:
| = Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

Also= mentioned the issue[1]:
| Resolves = tarantool/tarantool#6066


-- 
Best = regards,
Sergey Kaplun

[1]: https://github.com/tarantool/tarantool/issues/6066

-- 
Best = regards,
IM


[1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L= 119
[2]: https://github.com/LuaJIT/LuaJIT/issues/668

-- 
Best = regards,
IM


[1]: https://github.com/LuaJIT/LuaJIT/commit/7877369

-- 
Best = regards,
IM

= --Apple-Mail=_2C44BBBF-1293-421F-81B2-524D6CC9A962--