From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ED56AF5420F; Fri, 11 Oct 2024 21:37:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED56AF5420F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728671829; bh=VIfPD/dMdcjxpVdh13ac52O7vS63rv5lbFvaCCvjzKQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Z/A516cJosVgzZPn/XPEpJrY+5RbwH2YJesuQ4kaJHqKcFVckgqrto8Th75kCy+3b mQ5tptc7n0oReizF3qw85RHYRXYLZVZB01XzwDjK1l+N2L/AQ0X4HqrDMw8N/zCAlz wWe8WyObn6h5upkToLGi11Tu0wZeTpWNktHCvWqg= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0BA99596289 for ; Fri, 11 Oct 2024 21:37:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0BA99596289 Received: by exim-smtp-57f79c7799-kvcm4 with esmtpa (envelope-from ) id 1szKVe-000000000n3-422d; Fri, 11 Oct 2024 21:37:07 +0300 Date: Fri, 11 Oct 2024 21:37:05 +0300 To: Sergey Kaplun Message-ID: <2mst2bpxwtdb72ivhgezbreecwzrvfa6rs77dz5q5rjtfvqiy2@ap3jrgnzhojw> References: <15a3b416520eac8f799a59fa51c6dcd9515ec90b.1727172936.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15a3b416520eac8f799a59fa51c6dcd9515ec90b.1727172936.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B01871A0ED523BBFF2944416096D9CA3AE14DD4C63332AA4182A05F5380850402C6F82D09C30DFD13DE06ABAFEAF67056AB53203F1CD90378E3AF910ED86341E4C6875E6387C67AE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E2D36A15E1833D8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063719899BAB9B61B3948638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D840FFC05DE05DE1027A5DD7D06E329A66BEB16C85DB1CC560CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D8803F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C325C33BDE98D8A053BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7EE061C4D93700B7A731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A515BAF1FA55388FA05002B1117B3ED696F5FE9794FD1D0E9F0E58516B1639A14B823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCEE08DA39C69AF1892BF363A43F58C7B0BFE78FAE10565FFC694610DF76B98040FDE04257288300996F871248C7F69ECDB3E0E127EA91C2BC6033FF4140FC51C6057BECA38E6B8BD5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMU25eydo6+nWOfAxn6/2FQ== X-Mailru-Sender: E3D314023ABB569D87C73134501BE95A54975F7E997BB515A4D8CDA8385F280BFC8FE5255B1E848D28C44B9C631FF20DE747D2BC1AD30F01FB559BB5D741EB9612EB40C6FA10D71EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 5/7] test: shrink LUA_CPATH and {DY}LD_LIBRARY_PATH X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a single nit below. On Tue, Sep 24, 2024 at 01:29:50PM GMT, Sergey Kaplun wrote: > This patch sets the unique value of each of these variables for each of > the tests and only where they are needed. Also, it drops the comment > about SIP [1] tricks since it is obsolete after > 29897567ee5ed57e961c730432c056a3dbaa8f09 ("test: stop using > utils.selfrun in tests"). > > [1]: https://support.apple.com/en-us/HT204899 > > Resolves tarantool/tarantool#9898 > --- > test/tarantool-tests/CMakeLists.txt | 85 ++++++++----------- > test/tarantool-tests/ffi-ccall/CMakeLists.txt | 2 +- > .../fix-bit-shift-generation/CMakeLists.txt | 3 +- > .../gh-4427-ffi-sandwich/CMakeLists.txt | 3 +- > .../CMakeLists.txt | 3 +- > .../gh-6189-cur_L/CMakeLists.txt | 3 +- > .../lj-1004-oom-error-frame/CMakeLists.txt | 3 +- > .../CMakeLists.txt | 3 +- > .../lj-1166-error-stitch/CMakeLists.txt | 6 +- > .../lj-416-xor-before-jcc/CMakeLists.txt | 3 +- > .../CMakeLists.txt | 3 +- > .../lj-549-bytecode-loader/CMakeLists.txt | 3 +- > .../CMakeLists.txt | 3 +- > .../lj-601-fix-gc-finderrfunc/CMakeLists.txt | 3 +- > .../lj-727-lightuserdata-itern/CMakeLists.txt | 3 +- > .../CMakeLists.txt | 3 +- > .../lj-flush-on-trace/CMakeLists.txt | 3 +- > .../both/CMakeLists.txt | 4 +- > .../gnuhash/CMakeLists.txt | 4 +- > .../hash/CMakeLists.txt | 4 +- > .../stripped/CMakeLists.txt | 4 +- > 21 files changed, 82 insertions(+), 69 deletions(-) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index 5e3493b6..d0964aed 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -5,17 +5,16 @@ add_custom_target(tarantool-tests-libs > DEPENDS libluajit > ) > > -macro(BuildTestCLib lib sources) > - AddTestLib(${lib} ${sources}) > +macro(BuildTestCLib lib source for_tests) This whole macro signature now reads something like `lib source for_tests` which looks kind of misleading, especially in the code below. IMO, it would be better to call the last variable like `dependent_tests` for better readability. Feel free to ignore, though. -- > 2.46.0 >