From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9A8929E43D2; Thu, 1 Feb 2024 12:03:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A8929E43D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706778192; bh=dNoSVJ9WZOy++9CiuLYZpNXZXf1bcds5OxJvcuPyKG0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=O42VOK2WBxH3KRD1etho/0McT1VXkSArg2VYr52ziD/UZ70rGzxvl8xQu2sSWiEv/ 7yIdBkOxKgXUtZOt0fbLofOt5RP61mYZxfr7DijpowcctkwgEWM+YyIIzVx4M8+PTK Ft4WuQYCn7Y7vWEHlcz/0AlbKTPJ83y6I/kbvKNg= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 922F79E43D7 for ; Thu, 1 Feb 2024 12:03:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 922F79E43D7 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1rVSyU-00000003Ksg-2qMz; Thu, 01 Feb 2024 12:03:11 +0300 Date: Thu, 1 Feb 2024 12:03:10 +0300 To: Sergey Kaplun Message-ID: <2lngsqnj7bedymwutdfqi5vxsbv3onnz7pz3smlb3bp4sj2ia2@5zerlnx45qvd> References: <0399f0ad011d742bd3f90777e7e5d9b64f26e6d2.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0399f0ad011d742bd3f90777e7e5d9b64f26e6d2.1706520765.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93C58C36AA2E996499EFE771C80A3C579767E15D2D4E86957182A05F5380850404C228DA9ACA6FE279081F14524E25A4AA6D5EE0DB6E1EC8DABFD4DC1EC84388142E0A2E5ABDEE8B2FB1AA341019AC2B8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DD92412F72BDCE938638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A8C5C100A3DD88AC3F5FF6459D4565F3D38B77FC4B72FB7ACC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C0085B890FD2717DA302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C34B26726BD97DF1CFBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C9BE88FFEDFA497A35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A56733277A9C824B8A5002B1117B3ED696141CB43403116625F5FEB6EB1EB183FD823CB91A9FED034534781492E4B8EEAD1E02C13459908652BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCEB1D27C089A646A785A306A50C75DBD0A37B10768BA9BC20187AD8CE17848306BD4E2D2DF3D4047BAF4CF3B87E910B1D239B04A9F01C1392E923A36CF9960A2FAF0C2ECF77B359D5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtymIRLjNpat64g== X-Mailru-Sender: 7940E2A4EB16C9970E7603824FE97C20C47BDDCD47ABD60E84300F5183C62028F594A29891A845CDB6F7D78CE1F58EAD61AD1BC23DFB21333DDE9B364B0DF289BB83A8C3DAEBA78A61AAEF30F77CACB9EAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 19/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Please consider my comments below. On Mon, Jan 29, 2024 at 01:45:19PM +0300, Sergey Kaplun wrote: > This patch changes `dofile()` (which uses an unreliable relative file > path and mutates `_G` with global functions to be defined) to the > corresponding `require()` of the helper functions. It adds groups with > the names of subtests and enables the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua | 251 +++++++++--------- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 132 insertions(+), 120 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua > index c054bcfb..3b49648c 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua > @@ -1,131 +1,142 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > +local checkfail = require("common.ffi.checkfail") > +local checktypes = require("common.ffi.checktypes") > > -checkfail{ > - "", > - " ", > - "\n", > - "1", > - ".", > - ";", > - ",", > - "*", > - "[]", > - "()", > - "(*)", > - "//", > - "/*", > - "xyz", > - "const", > - "volatile", > - "typedef", > - "extern", > - "static", > - "auto", > - "register", > - "struct", > - "union", > - "sizeof", > - "int int", > - "int char", > - "int double", > - "int;", > -} > +do --- checkfail I would prefer a more elaborate name here. > + checkfail{ > + "", > + " ", > + "\n", > + "1", > + ".", > + ";", > + ",", > + "*", > + "[]", > + "()", > + "(*)", > + "//", > + "/*", > + "xyz", > + "const", > + "volatile", > + "typedef", > + "extern", > + "static", > + "auto", > + "register", > + "struct", > + "union", > + "sizeof", > + "int int", > + "int char", > + "int double", > + "int;", > + } > +end