From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F21E66BA5BA; Wed, 18 Oct 2023 13:01:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F21E66BA5BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1697623293; bh=EaVnCI24U/dftRhudOybz/L51d8bIXCrwoJJPm8N7+o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gc99DW17OLpqD3Xt5I8UspQab6PXa/lWd3oUAormAUyucREKbAXVeuyqWS8+tvIIW VZZwQvpGKha6nGC75EUBayCsBjY8cdCUmOH7Nx+f7zmGY2xaaoawP8nBJ/OqP24/oo FER7hpcBuIrk6ppRJh3XWgpiTIMsD4/BgBcUrVak= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [95.163.41.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE1DD42FB48 for ; Wed, 18 Oct 2023 13:01:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CE1DD42FB48 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1qt3Mo-002sYL-16; Wed, 18 Oct 2023 13:01:31 +0300 Date: Wed, 18 Oct 2023 13:01:13 +0300 To: Sergey Kaplun Message-ID: <2i3tloyngwkxx4jck3wl557qhazb7xkl6zpfizrw6tmltyqnlo@ub2ls7yzxaey> References: <20231003151133.13730-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD978AFEFB3096932CF13E7FB3349EB8EC0C23B91B6439F56BB182A05F5380850400C9BA047BBB9F254689C593C8907F9A748ACA5FD52974DAFB38908242935282F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76ABD3380F320B62CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370F98874192B1BA168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8413DCBCB69FCB73FF9297F30333F39F0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8ED96AA85C75E140D117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF302A61B22DEE7324BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6C7D34837DDB94D5A76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249BAA8CD687FCDB2EBE827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5E8CA71CD60F6732ABBFD93698751D061D759798B220883C4F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA78C90FA3AF6B7DF20F4382A7715E5D41458F4B988A6DC90A49C3D6CA973487AA53151558601347D5BB39EF8E370AEAD5F67BF0AAEAF17DC0A83C49BD24F4AECA74DFFEFA5DC0E7F02C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+FeGWQZfdZKdSxTuwuOMnA== X-Mailru-Sender: 7940E2A4EB16C997A697C250BADECD3DF7A7B9C4724BBEA9954A8B87FDF9F884E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix Clang build. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for you review. Here is the diff with changes, branch is force-pushed. === diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 2c637124..cb4ba57b 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -35,6 +35,7 @@ jobs: BUILDTYPE: [Debug, Release] GC64: [ON, OFF] OS: [Linux, macOS] + CC: [gcc, clang] include: - BUILDTYPE: Debug CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON @@ -45,12 +46,18 @@ jobs: GC64: OFF - OS: macOS GC64: OFF + - OS: macOS + CC: gcc + - ARCH: ARM64 + OS: Linux + CC: clang runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}'] name: > LuaJIT (${{ matrix.OS }}/${{ matrix.ARCH }}) ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} + CC:${{ matrix.CC }} steps: - uses: actions/checkout@v3 with: @@ -64,6 +71,7 @@ jobs: if: ${{ matrix.OS == 'macOS' }} - name: configure run: > + CC=${{ matrix.CC }} cmake -S . -B ${{ env.BUILDDIR }} -G Ninja ${{ matrix.CMAKEFLAGS }} === On Mon, Oct 09, 2023 at 12:13:51PM +0300, Sergey Kaplun wrote: > Hi, Max! > Thanks for the patch! > Please, consider my comment below. > > On 03.10.23, Maksim Kokryashkin wrote: > > From: Mike Pall > > > > > > > > > No tests were added since the issue is relevant for a very > > specific type of very old clang 10.0.0, which is not really > > relevant for us. > > Indeed, but we should add the testing of clang build to our CI. > I suppose we may check the following matrix: > - [GC64, !GC64] > - [Debug, Release] > - Linux only > ARM64 may be omitted for now since it isn't our target platform. > > It should be done aside from ASAN testing just to verify correctness > under this compiler. Should be easily added to the `test-luajit` matrix > in the <.github/workflows/testing.yml>: > > > > > Maxim Kokryashkin: > > * added the description for the problem > > > > Part of tarantool/tarantool#9145 > > --- > > PR: https://github.com/tarantool/tarantool/pull/9215 > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build > > Issue: https://github.com/luajit/luajit/issues/595 > > > > -- > Best regards, > Sergey Kaplun