From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5EB02445320 for ; Sun, 5 Jul 2020 12:11:27 +0300 (MSK) References: <4e2a3c4e8c51bf6eabf37713e4b34d18e15283c5.1593733161.git.v.shpilevoy@tarantool.org> From: Serge Petrenko Message-ID: <2f0e1f4d-d4f4-7cff-c0c1-5e906f02bfbf@tarantool.org> Date: Sun, 5 Jul 2020 12:11:26 +0300 MIME-Version: 1.0 In-Reply-To: <4e2a3c4e8c51bf6eabf37713e4b34d18e15283c5.1593733161.git.v.shpilevoy@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH 5/5] [tosquash] replication: add test on local row in the end of sync txn List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org 03.07.2020 02:40, Vladislav Shpilevoy пишет: > Currently disabled, because soon should start working without > any changes when #4928 is fixed. > --- > test/replication/qsync_basic.result | 20 ++++++++++++++++++++ > test/replication/qsync_basic.test.lua | 20 ++++++++++++++++++++ > 2 files changed, 40 insertions(+) > > diff --git a/test/replication/qsync_basic.result b/test/replication/qsync_basic.result > index 339fc0e33..83ff7d3d1 100644 > --- a/test/replication/qsync_basic.result > +++ b/test/replication/qsync_basic.result > @@ -419,6 +419,26 @@ box.space.test:select{9} > | - [] > | ... > > +-- > +-- gh-4928: test that a sync transaction works fine with local > +-- rows in the end. > +-- > + > +-- test_run:switch('default') > +-- box.cfg{replication_synchro_timeout = 1000, replication_synchro_quorum = 2} > +-- do \ > +-- box.begin() \ > +-- box.space.sync:replace{10} \ > +-- box.space.locallocal:replace({10}) \ > +-- box.commit() \ > +-- end > +-- box.space.sync:select{10} > +-- box.space.locallocal:select{10} > + > +-- test_run:switch('replica') > +-- box.space.sync:select{10} > +-- box.space.locallocal:select{10} > + > -- > -- gh-5123: quorum 1 still should write CONFIRM. > -- > diff --git a/test/replication/qsync_basic.test.lua b/test/replication/qsync_basic.test.lua > index 6e40131bf..74083a0b9 100644 > --- a/test/replication/qsync_basic.test.lua > +++ b/test/replication/qsync_basic.test.lua > @@ -163,6 +163,26 @@ box.space.sync:select{9} > box.space.locallocal:select{9} > box.space.test:select{9} > > +-- > +-- gh-4928: test that a sync transaction works fine with local > +-- rows in the end. > +-- > + > +-- test_run:switch('default') > +-- box.cfg{replication_synchro_timeout = 1000, replication_synchro_quorum = 2} > +-- do \ > +-- box.begin() \ > +-- box.space.sync:replace{10} \ > +-- box.space.locallocal:replace({10}) \ > +-- box.commit() \ > +-- end > +-- box.space.sync:select{10} > +-- box.space.locallocal:select{10} > + > +-- test_run:switch('replica') > +-- box.space.sync:select{10} > +-- box.space.locallocal:select{10} > + > -- > -- gh-5123: quorum 1 still should write CONFIRM. > -- Hi! Thanks for the test! LGTM with one comment. Looks like it relies on the vclock[0] increase you performed in the previous test (patch 4/5). If it wasn't for this increase,both correctly and incorrectly working tarantools would complete the transaction. (The incorrect one would take lsn = 1 from vclock[0]) Maybe add the same increase here, to make sure the test stays valid if someone changes the previous test case? I mean the `for i = 1,2000 do box.space.localocal:replace{1} end` -- Serge Petrenko