From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B3DEF7034B; Fri, 6 Aug 2021 01:17:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B3DEF7034B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628201853; bh=lRxn4RB3Q5VljE1k4Cp+cGAUxYNLgoX/uVZ/X3p7Jxg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Wp8ednPwFv3Mvzay8EDVIheVwLD7uQxOiSKVUJrBdbuYSMOJA2fu/ixw1I+2eO3zM +86YGVbgFvtffV5wvwXyqJNczHxZh7gBsHsjU5PAUBDIj6ORChsa5m0h2PfRwVmuYw w4RAiJOeOksrLCL7wd+j+hcknDiKr2xtyeJfrOWw= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F102B7034B for ; Fri, 6 Aug 2021 01:17:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F102B7034B Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1mBlgB-00024G-B3; Fri, 06 Aug 2021 01:17:31 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <6033113bc5174be7b6e2b38b7dc07a2c61755e13.1628081224.git.imeevma@gmail.com> Message-ID: <2e871a92-4bd0-faae-2bc3-2dc9948757ce@tarantool.org> Date: Fri, 6 Aug 2021 00:17:30 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6033113bc5174be7b6e2b38b7dc07a2c61755e13.1628081224.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD972FF4A7D76DB5E242D14FEF1BD8BF4AC182A05F538085040F3DB0E3E5DAC4C02F9055B622A7DED96EB8371B9FC7EE774C2F54DAF21B64099 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77F4CDA15A4A01EA0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376473F174BDE74BA48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D800D536B4F0755D201C6CC176B9CC1670117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD86750DBF4DC650F2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE31E44367C8E80A7B4BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE72F88032165008D51731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D94463893BF8742D013FDFF6E1ABC51E4 X-C1DE0DAB: 0D63561A33F958A56103B68053ED77C9AF9D7CEE68BA1FD22F668AF530F42B1DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455049D7B43D89D648DBCE5C54F1A95406A2641B3A89D5FEBCD0E751A26D1DD6691470B0B3AC6A20D1D7E09C32AA3244C45DF0602A89BD638324A0CBF76663FDF6C24832127668422729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwSwIZr4iCOpqw== X-Mailru-Sender: 1F3202E75A95DDEFC23907419AE0C7D70E2721CE0D9746127AD88C13AF7E9FBFC94EFE03928107DF07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 4/6] alter: parse data dictionary version X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/schema.cc b/src/box/schema.cc > index 963278b19..35026619a 100644 > --- a/src/box/schema.cc > +++ b/src/box/schema.cc > @@ -70,6 +71,9 @@ uint32_t schema_version = 0; > */ > uint32_t space_cache_version = 0; > > +/** Persistent version of the schema, stored in _schema["version"]. */ > +uint32_t dd_version_id = tarantool_version_id(); I propose to assign it to 0. Because at start there is no schema at all until box.cfg{} is called first time. (Also then version.h include could be dropped above.) > + > struct rlist on_schema_init = RLIST_HEAD_INITIALIZER(on_schema_init); > struct rlist on_alter_space = RLIST_HEAD_INITIALIZER(on_alter_space); > struct rlist on_alter_sequence = RLIST_HEAD_INITIALIZER(on_alter_sequence);