From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 0/5] Router backoff, storage disable
Date: Sat, 18 Dec 2021 16:58:10 +0300 [thread overview]
Message-ID: <2e380c6a-d015-f59f-1dac-fd1b4e01c724@tarantool.org> (raw)
In-Reply-To: <cover.1639700518.git.v.shpilevoy@tarantool.org>
Thanks for your patchset. LGTM.
On 17.12.2021 03:25, Vladislav Shpilevoy wrote:
> The patchset introduces vshard.storage auto and manual enable/disable. Disabled
> storage blocks most of public API calls. The state is handled by the router in
> a special way so it transparently retries requests failed due to the storage
> being disabled.
>
> Branch:http://github.com/tarantool/vshard/tree/gerold103/gh-298-replica-backoff-part-2
> Issue:https://github.com/tarantool/vshard/issues/298
>
> Vladislav Shpilevoy (5):
> router: backoff on some box errors
> storage: auto enable/disable
> storage: manual enable/disable
> error: introduce from_string
> router: backoff on storage being disabled
>
> example/localcfg.lua | 1 -
> test/router/router2.result | 325 ++++++++++++++++++++++++++++++++++
> test/router/router2.test.lua | 132 ++++++++++++++
> test/storage/storage.result | 128 +++++++++++++
> test/storage/storage.test.lua | 55 ++++++
> test/unit/error.result | 18 ++
> test/unit/error.test.lua | 6 +
> test/unit/garbage.result | 17 +-
> test/unit/garbage.test.lua | 15 +-
> test/unit/rebalancer.result | 2 +-
> test/unit/rebalancer.test.lua | 2 +-
> vshard/consts.lua | 1 +
> vshard/error.lua | 32 +++-
> vshard/replicaset.lua | 119 +++++++++++--
> vshard/router/init.lua | 3 +-
> vshard/storage/init.lua | 207 +++++++++++++++++-----
> 16 files changed, 987 insertions(+), 76 deletions(-)
>
next prev parent reply other threads:[~2021-12-18 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 0:25 Vladislav Shpilevoy via Tarantool-patches
2021-12-17 0:25 ` [Tarantool-patches] [PATCH vshard 1/5] router: backoff on some box errors Vladislav Shpilevoy via Tarantool-patches
2021-12-17 11:09 ` Oleg Babin via Tarantool-patches
2021-12-17 23:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-12-18 13:57 ` Oleg Babin via Tarantool-patches
2021-12-17 0:25 ` [Tarantool-patches] [PATCH vshard 2/5] storage: auto enable/disable Vladislav Shpilevoy via Tarantool-patches
2021-12-17 11:09 ` Oleg Babin via Tarantool-patches
2021-12-17 23:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-12-18 13:58 ` Oleg Babin via Tarantool-patches
2021-12-17 0:25 ` [Tarantool-patches] [PATCH vshard 3/5] storage: manual enable/disable Vladislav Shpilevoy via Tarantool-patches
2021-12-17 11:09 ` Oleg Babin via Tarantool-patches
2021-12-17 0:25 ` [Tarantool-patches] [PATCH vshard 4/5] error: introduce from_string Vladislav Shpilevoy via Tarantool-patches
2021-12-17 11:09 ` Oleg Babin via Tarantool-patches
2021-12-17 23:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-12-17 0:25 ` [Tarantool-patches] [PATCH vshard 5/5] router: backoff on storage being disabled Vladislav Shpilevoy via Tarantool-patches
2021-12-17 11:09 ` Oleg Babin via Tarantool-patches
2021-12-18 13:58 ` Oleg Babin via Tarantool-patches [this message]
2021-12-20 23:52 ` [Tarantool-patches] [PATCH vshard 0/5] Router backoff, storage disable Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e380c6a-d015-f59f-1dac-fd1b4e01c724@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 0/5] Router backoff, storage disable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox