From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 76240469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  9 Mar 2020 01:16:03 +0300 (MSK)
References: <20200305113600.65203-1-sergepetrenko@tarantool.org>
 <f2f5ec85-8519-655e-0726-11dcd84159b4@tarantool.org>
 <C1725E50-E5BF-4AB3-8581-0D85C16B7A70@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2e299aec-23c8-400d-8daf-3f7f8d015c48@tarantool.org>
Date: Sun, 8 Mar 2020 23:16:01 +0100
MIME-Version: 1.0
In-Reply-To: <C1725E50-E5BF-4AB3-8581-0D85C16B7A70@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use
	type uint32_t
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

I think you can just merge the second commit into the
first one. If you don't want, then prepend that commit's
title with a subsystem name.

    xrow: use bit_count_u32() for replica_id filter

instead of

    use bit_count_u32() for replica_id filter

After that LGTM.