From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6F464278F8
	for <tarantool-patches@freelists.org>; Thu, 29 Aug 2019 16:43:20 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id OV7zM_4eJRrQ for <tarantool-patches@freelists.org>;
	Thu, 29 Aug 2019 16:43:20 -0400 (EDT)
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 29E0E278D1
	for <tarantool-patches@freelists.org>; Thu, 29 Aug 2019 16:43:18 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 3/8] sql: remove sql_prepare_v2()
References: <cover.1566907519.git.korablev@tarantool.org>
 <021a598a8eae9b76f74a8caa5d73a8243b9b3565.1566907520.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2e1d2d22-6e6b-934c-a2b8-f19a5819ba29@tarantool.org>
Date: Thu, 29 Aug 2019 22:46:32 +0200
MIME-Version: 1.0
In-Reply-To: <021a598a8eae9b76f74a8caa5d73a8243b9b3565.1566907520.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Cc: kostja@tarantool.org, alexander.turenko@tarantool.org

Thanks for the patch!

LGTM.

On 27/08/2019 15:34, Nikita Pettik wrote:
> There are two versions of the same function (sql_prepare()) which are
> almost identical. Let's keep more relevant version sql_prepare_v2() but
> rename it to sql_prepare() in order to avoid any mess.
> 
> Needed for #3292

Seems like simple refactoring. And can be pushed out of order.