From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CFDFC1C0200F; Wed, 29 Apr 2026 12:55:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CFDFC1C0200F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1777456529; bh=f5dqn9XRAkCe+qELjWvDwHSteHKe3aMiwgPR/V0tJLg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YySwuueJSGd7UYJZgY7oMVb2iBNKiV2raa2fQh5C+MApc03xuNpHSQXQWQfbeX/QE I5KN9fgk9olvuCG6i9I8eghvMJnPjoFiF1Wz2fmzzhbZlEA/zMcy8E+QFMKNAFUG6b 8KvbtOoKrQ807PcTeK2lmco3z4ub6ejIJl9exMh4= Received: from send278.i.mail.ru (send278.i.mail.ru [95.163.59.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1E8D81C0200F for ; Wed, 29 Apr 2026 12:55:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1E8D81C0200F Received: by exim-smtp-6767fb646-l2s9c with esmtpa (envelope-from ) id 1wI1df-00000000FZy-0mq7; Wed, 29 Apr 2026 12:55:27 +0300 Content-Type: multipart/alternative; boundary="------------X0QPKKirzlwj38aKCWQBm0Ty" Message-ID: <2c608e1b-cb9e-42f0-8e51-1560d4c5f4b3@tarantool.org> Date: Wed, 29 Apr 2026 12:55:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <20260423170806.9647-1-skaplun@tarantool.org> <398afbb0-66c6-4935-878f-ed01356fe740@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9DA546775E7411B7C7A213BC7EA003E202FE17F4123866A2700894C459B0CD1B9689C710B6C253607411046492FDDF80605145D07F5B5766A2EF0D8DEAB530FBEDAEE934B56E2D9F8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7DBA72CFE7C57007CEA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658F92CF7EDD58DD2544F73D3233A2A14BEC5E98642E2DDDFC3117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B630C12C51E7AE69A2089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F6B097E510DEF9A95002B1117B3ED6965389AEF17099BB87C66B2B37046EC955823CB91A9FED034534781492E4B8EEAD9CFA8CFAC159CE19BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659AB271BF2750A0109FE30B2204DB0FCC3E90092C73D5CA13361CF9BC26B4A717E0D1B8D7C24F56F68B8341EE9D5BE9A0A1D7572544FF1DDE697C32A86EC448F80081CB52094A3C2A76536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVW+UUD87bVUoswMHY1RRnJI= X-DA7885C5: 196278A984C82896F255D290C0D534F97A5AA618135CB9F3C7646F1009E41EB4033DE1869A43F6AC5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2913A690EFE17487BBD64F8D78B22EFFB833BF4806A7F2C80EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: conditionally install lua-cjson for perf job X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------X0QPKKirzlwj38aKCWQBm0Ty Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, thanks for the comments. LGTM after updating a commit message. Sergey On 4/28/26 15:29, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answers below. > > On 28.04.26, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> A few things worry me: we still don't know the root cause of the problem. > It should be investigated and fixed in the scope of the 12600 [1]. For > LuaJIT's CI, this workaround works just fine. Probably it is worth to add to the issue that the problem is affected LuaJIT CI as well. > >> The proposed patch merely reduces the frequency of module installations. > Yes, it installs the module only once. > >> And if an installation is required, the installation will still break. > Not always, it usually passes successfully and fails only on the fourth > run. So, 1 successful installation is enough to prevent flakiness, which > is OK for our needs in LuaJIT. It is better to have some statistics > instead of having none, isn't it? Agree. >> See comments inline. >> >> Sergey >> >> On 4/23/26 20:08, Sergey Kaplun wrote: >>> We have encountered the flakiness of the network on our CI runners. It >>> happens only on lua-cjson installation and only in some particular job >>> run. >>> >>> This patch helps to deal with it by installing this package only if it >> s/helps to deal with it/helps to reduce a number of installations/ > Don't get the comment about the number of installations. Maybe rephrase > it like the following? > | This patch workarounds it by installing the package only if ... Ok, let's rephrase like you suggested. Also, it is worth referring to the issue #12600 ("See also #12600"). > >>> is not installed in the system. Also, it installs it only for Lua 5.1, >>> which is compatible with LuaJIT. >>> --- >>> >>> Branch:https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson >>> >>> .github/actions/setup-performance/action.yml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml >>> index 4e0e1929..3c2a8230 100644 >>> --- a/.github/actions/setup-performance/action.yml >>> +++ b/.github/actions/setup-performance/action.yml >>> @@ -11,7 +11,9 @@ runs: >>> apt install -y curl luarocks util-linux >>> shell: bash >>> - name: Install Lua modules >>> - run: luarocks install lua-cjson >>> + run: > >>> + luarocks --lua-version=5.1 show lua-cjson || >>> + luarocks --lua-version=5.1 install lua-cjson >> Why do we need specifying Lua version now? Previously, it worked without >> setting exact version. > I've preferred to describe it specifically since the most modern distros > provide Lua 5.3+ by default. Should I add the comment in the commit > message? Yes, please. > >>> shell: bash >>> - name: Run script to setup Linux environment >>> run: sh ./perf/helpers/setup_env.sh > [1]:https://github.com/tarantool/tarantool/issues/12600 > --------------X0QPKKirzlwj38aKCWQBm0Ty Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi,

thanks for the comments. LGTM after updating a commit message.

Sergey

On 4/28/26 15:29, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 28.04.26, Sergey Bronnikov wrote:

Hi, Sergey!

A few things worry me: we still don't know the root cause of the problem.

It should be investigated and fixed in the scope of the 12600 [1]. For
LuaJIT's CI, this workaround works just fine.
Probably it is worth to add to the issue that the problem is affected LuaJIT CI as well.  


The proposed patch merely reduces the frequency of module installations.

Yes, it installs the module only once.


And if an installation is required, the installation will still break.

Not always, it usually passes successfully and fails only on the fourth
run. So, 1 successful installation is enough to prevent flakiness, which
is OK for our needs in LuaJIT. It is better to have some statistics
instead of having none, isn't it?
Agree. 

      

        
See comments inline.

Sergey

On 4/23/26 20:08, Sergey Kaplun wrote:


        

          
We have encountered the flakiness of the network on our CI runners. It
happens only on lua-cjson installation and only in some particular job
run.

This patch helps to deal with it by installing this package only if it


        

        
s/helps to deal with it/helps to reduce a number of installations/


      

      
Don't get the comment about the number of installations. Maybe rephrase
it like the following?
| This patch workarounds it by installing the package only if ...

    

    
Ok, let's rephrase like you suggested. 

    
Also, it is worth referring to the issue #12600 ("See also
      #12600").

    

      



      

        

          
is not installed in the system. Also, it installs it only for Lua 5.1,
which is compatible with LuaJIT.
---

Branch:https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson

  .github/actions/setup-performance/action.yml | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml
index 4e0e1929..3c2a8230 100644
--- a/.github/actions/setup-performance/action.yml
+++ b/.github/actions/setup-performance/action.yml
@@ -11,7 +11,9 @@ runs:
          apt install -y curl luarocks util-linux
        shell: bash
      - name: Install Lua modules
-      run: luarocks install lua-cjson
+      run: >
+        luarocks --lua-version=5.1 show lua-cjson ||
+        luarocks --lua-version=5.1 install lua-cjson


        

        
Why do we need specifying Lua version now? Previously, it worked without 
setting exact version.


      

      
I've preferred to describe it specifically since the most modern distros
provide Lua 5.3+ by default. Should I add the comment in the commit
message?

    

    Yes, please.
    

      



      

        

          
        shell: bash
      - name: Run script to setup Linux environment
        run: sh ./perf/helpers/setup_env.sh


        

      

      
[1]: https://github.com/tarantool/tarantool/issues/12600



    

  
  


--------------X0QPKKirzlwj38aKCWQBm0Ty--