From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DAD5690AC20; Wed, 20 Dec 2023 15:23:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DAD5690AC20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1703075023; bh=4AG4I3/t9ROk1jm3xwyOu9cawi4qmxGxUVU6Tn5sssU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yd1CPXjAV18W/kh4wVv69aYNAnO2QT8ACB5ppk7u1lkcQLDlfVeJ9EOwnV7J4BQl+ MkruG68fMoe2YiB2hRiH/wrkObeKeuGSw+9BSTrw7PuJoV+GHLS44I2AI5gSJ2Sp8K qShNAOk1qIzPqK2O3Qr9VZ8P0Q3C1KGGiBvsxCb8= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [95.163.41.100]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EDEB272FFD8 for ; Wed, 20 Dec 2023 15:23:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EDEB272FFD8 Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1rFvbv-000xef-1f; Wed, 20 Dec 2023 15:23:39 +0300 Message-ID: <2c02e187-ec13-4d3f-8a7f-b45ae4b62d2a@tarantool.org> Date: Wed, 20 Dec 2023 15:23:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97533543916A0F71A7F5FD72A6F01437A2062B641662DAC10CD62213F67905E7A981D8338C7D5FB8DCA9A02665D802951BC4DFD9CB8B5252F22E3706512C1278F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD60A286D0BA57028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8660F68A64AD8BA08CC3270D6CB4C9A0C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC587F3D2152687E5CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B107FB45A5F6E725C8D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3632EDEA9CD5989A39735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F0A35B161A8BF67C1156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5438E9BAF3D4FDFE8BECB6E4E82EE2718C6615A230ED7E0A6F87CCE6106E1FC07E67D4AC08A07B9B0724336BCC0EE1BA8CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E20F2278F74481A19B5A28D854966916E08936F7C8E24D744A3A93EC250E4CE5BAE5E2C0D26A04441D7E09C32AA3244CAA32EB57C47B86CB9D4449CC43BACD351DD47778AE04E04DED9A463B7D0AAFF65DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYtkvzPaMmB7r1DK2Q+1z1g== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7690F820459D90730620FE1536819BF9E82C479C2914A57FB1FEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks again, LGTM. On 12/19/23 17:34, Maxim Kokryashkin wrote: > Hi! > Thanks for the review! > Fixed your comments, except for the comment about CMake policy. The > policy you've mentioned is too new to include in our CMakeLists.txt. > > Branch is force pushed, diff is below: > ===