From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 284C54696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 02:54:52 +0300 (MSK)
References: <cover.1582709303.git.sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2b8790c2-b5b9-07c2-3c83-5385e5f6096f@tarantool.org>
Date: Thu, 27 Feb 2020 00:54:50 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1582709303.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of
 rows originating from local instance
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergepetrenko <sergepetrenko@tarantool.org>, kirichenkoga@gmail.com, kostja.osipov@gmail.com, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

Please, add a @ChangeLog record.

On 26/02/2020 11:00, sergepetrenko wrote:
> https://github.com/tarantool/tarantool/issues/4739
> https://github.com/tarantool/tarantool/tree/sp/gh-4739-vclock-assert-v4
> 
> Changes in v4:
>   - move row skipping logic from recovery to relay
>   - encode a list of instances whose rows to skip
>     in SUBSCRIBE request insead of encoding
>     is_orhpan status
> 
> Changes in v3:
>   - review fixes as per review from Vlad
>   - instead of skipping rows on replica side,
>     do it on master side, by patching recovery
>     to silently follow rows coming from a certain
>     instance.
> 
> Changes in v2:
>  - review fixes as per review from Kostja
> 
> Serge Petrenko (4):
>   box: expose box_is_orphan method
>   wal: warn when trying to write a record with a broken lsn
>   replication: implement an instance id filter for relay
>   replication: do not relay rows coming from a remote instance back to
>     it
> 
>  src/box/applier.cc         |  3 ++-
>  src/box/box.cc             | 13 +++++++++---
>  src/box/box.h              |  3 +++
>  src/box/iproto_constants.h |  1 +
>  src/box/relay.cc           |  9 ++++++++-
>  src/box/relay.h            |  3 ++-
>  src/box/wal.c              | 17 +++++++++++++---
>  src/box/xrow.c             | 41 +++++++++++++++++++++++++++++++++++---
>  src/box/xrow.h             | 34 +++++++++++++++++++++----------
>  9 files changed, 101 insertions(+), 23 deletions(-)
>