From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D62A74696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 19:56:53 +0300 (MSK)
References: <cover.1585954493.git.sergepetrenko@tarantool.org>
 <9042734e4ddc49d2e8903b346b84d699d1e2c46b.1585954493.git.sergepetrenko@tarantool.org>
 <d749e0a6-56d8-d33f-f304-6a04607030f3@tarantool.org>
 <61D44098-8826-479E-A7F9-E1122410A057@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2b3e67d6-ce8b-2c52-b9c9-6ea5f5f666ae@tarantool.org>
Date: Fri, 10 Apr 2020 18:56:52 +0200
MIME-Version: 1.0
In-Reply-To: <61D44098-8826-479E-A7F9-E1122410A057@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 2/4] uuid: expose additional
 from_string constructors
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

>> 6 апр. 2020 г., в 00:22, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
>>
>> Thanks for the patch!
>>
>>> diff --git a/src/lib/uuid/tt_uuid.c b/src/lib/uuid/tt_uuid.c
>>> index 1bd2e2cfe..94a0b15bb 100644
>>> --- a/src/lib/uuid/tt_uuid.c
>>> +++ b/src/lib/uuid/tt_uuid.c
>>> @@ -65,6 +65,15 @@ tt_uuid_create(struct tt_uuid *uu)
>>> }
>>> #endif
>>>
>>> +extern inline int
>>
>> 'inline' modifier won't change anything. The function body is
>> not visible anyway.
> 
> Not sure about that.
> What about other functions?
> 
> ```
> extern inline int                                                                   
> tt_uuid_from_string(const char *in, struct tt_uuid *uu);
> ```
> 
> I’m still not sure what ‘extern inline’ does, but I googled a stackoverflow
> question discussing it:
> https://stackoverflow.com/questions/216510/what-does-extern-inline-do

>From what I understood by the link above and here: http://m68hc11.serveftp.org/inline-1.php
it looks like 'extern inline' does not make any sense for function
declaration. It should be used only for function definition in a
header file.