From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3D30F278DA
	for <tarantool-patches@freelists.org>; Fri, 20 Jul 2018 10:15:23 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id kF1BHElYWiSU for <tarantool-patches@freelists.org>;
	Fri, 20 Jul 2018 10:15:23 -0400 (EDT)
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EE51F20FC9
	for <tarantool-patches@freelists.org>; Fri, 20 Jul 2018 10:15:22 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/3] Add test on error during
 reconfigure
References: <cover.1531935745.git.avkhatskevich@tarantool.org>
 <0a1a6702a293c8f86f38d67c92f04da1f6c6a686.1531935745.git.avkhatskevich@tarantool.org>
 <069d5b60-cffa-c24c-06f9-9a9af1af8fcb@tarantool.org>
 <95eccf6c-67fc-d9a5-f3d7-a5b276d1ea88@tarantool.org>
 <10bcefd6-a696-41fa-3598-900cf96c32a3@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2aa4c0f0-338c-b157-bb7d-0e7fca1fcdb0@tarantool.org>
Date: Fri, 20 Jul 2018 17:15:20 +0300
MIME-Version: 1.0
In-Reply-To: <10bcefd6-a696-41fa-3598-900cf96c32a3@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Alex Khatskevich <avkhatskevich@tarantool.org>

Hi! Thanks for the fixes! I have pushed my review output
in a separate commit on the branch. Please, look, run tests
and squash.

On 20/07/2018 14:34, Alex Khatskevich wrote:
> Here is a full diff:
> 
> commit fd68ec9454ec6b5552a37d15bb3adb33cbf1ea84
> Author: AKhatskevich <avkhatskevich@tarantool.org>
> Date:   Sat Jun 9 19:50:52 2018 +0300
> 
>      Add test on error during reconfigure
> 
>      In case reconfigure process fails, the node should continue
>      work properly.
>