From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 884524696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 11 Apr 2020 19:54:32 +0300 (MSK)
References: <cover.1586341316.git.sergeyb@tarantool.org>
 <8753132aaa1c161714064bb97ffcd97e0231c586.1586341316.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2a256771-68aa-df00-6522-eb99e91cf1ee@tarantool.org>
Date: Sat, 11 Apr 2020 18:54:29 +0200
MIME-Version: 1.0
In-Reply-To: <8753132aaa1c161714064bb97ffcd97e0231c586.1586341316.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 2/6] Fix luacheck warnings in
	test/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <estetus@gmail.com>, tarantool-patches@dev.tarantool.org
Cc: o.piskunov@tarantool.org

Hi! Thanks for the patch!

> diff --git a/test/box/iproto_stress.result b/test/box/iproto_stress.result
> index 7149d6c52..3b5b0a031 100644
> --- a/test/box/iproto_stress.result
> +++ b/test/box/iproto_stress.result
> @@ -76,13 +76,13 @@ test_run:wait_cond(function() return n_workers == 0 end, 60)
>  ---
>  - true
>  ...
> -n_workers -- 0
> +assert(n_workers == 0)

These changes should not be done, IMO. Most of our
tests are diff based, and therefore it is ok to write
a statement just to print it. It is not only simpler, but
also allows to print the actual value, if it didn't match
the expected value.

For example, if n_workers becomes not 0, we would see its
actual value in the diff. When we use assert(), we won't
see anything except an error message 'assertion failed'.

I propose to allow writing non-functional statements in
test/ dir.