From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB6906F3C7; Fri, 26 Mar 2021 14:30:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB6906F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616758248; bh=xTGS116c2LBKyjU6KqGc+N49dYYC7eQSiX7wcc9Hmzk=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TDluTFrOZPS7/ZGIYt3EhIbB1YudI58VVfGz1Igk/FQdth5SjUQa9ycxxnMzwzUOR iUTxHcrNbm5MuES//CRSbO9Z1bXvIa9iDHHJNFJnh0mOsl4k5h4CbB3Rewtkl9TkvJ e8jXfvyxuWySOh9M1ZRdOphroqF2IwK+e3R0ewMk= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9B3986F3C7 for ; Fri, 26 Mar 2021 14:30:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B3986F3C7 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1lPkfu-0007LL-To; Fri, 26 Mar 2021 14:30:47 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <8c3a82ed0ae8147468aad1a9fbf4987ebf641669.1616743343.git.skaplun@tarantool.org> Date: Fri, 26 Mar 2021 14:30:45 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <2F0A362C-C57F-446D-8BF7-D109AFB95D4D@tarantool.org> References: <8c3a82ed0ae8147468aad1a9fbf4987ebf641669.1616743343.git.skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE993662DB34D9B1ABD5A9410DDDE83AB43182A05F538085040A1AF4A5C1EE16284F020A7746965F6601107B3A1898973DEEB2CCBEA1000B32A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D54C5F39E9A2C08104461505F7705F19FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE764603B5C71CE8B8F9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C362968DCAA3E4B45B117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FD7D1589A41AECE4343A08E932364E7DA267C8F425094116D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348CDF4129B2EA8560A08D448A11F1FF90BFF19588183495969B1386C873880C91CAE5506C2D352A9D1D7E09C32AA3244C0E0B751C1E733B65202783B38828310EC3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAjxta6N9P5ySw== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81ED24B6B125A148CB1743372AEC63C273ABE399A2A6377AE13AD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 07/30] test: disable Lua tests for bytecode with header X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM. Sergos > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: >=20 > Loading bytecode with an extra header (BOM or "#") is disabled > for security reasons since LuaJIT-2.0.0-beta10. > For more information see comment for `lj_lex_setup()` > in . > Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47 > (Disable loading bytecode with an extra header (BOM or #!).). >=20 > These tests are disabled for LuaJIT. >=20 > Relates to tarantool/tarantool#5691 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/main.lua | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/main.lua = b/test/PUC-Lua-5.1-tests/main.lua > index 56f56a0..cf6d533 100644 > --- a/test/PUC-Lua-5.1-tests/main.lua > +++ b/test/PUC-Lua-5.1-tests/main.lua > @@ -158,13 +158,23 @@ prepfile(s) > prepfile[[#comment in 1st line without \n at the end]] > RUN("lua %s", prog) >=20 > +-- Loading bytecode with an extra header (BOM or "#") is disabled > +-- for security reasons since LuaJIT-2.0.0-beta10. > +-- For more information see comment for `lj_lex_setup()` > +-- in . > +-- Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47 > +-- (Disable loading bytecode with an extra header (BOM or #!).). > +-- See also https://github.com/tarantool/tarantool/issues/5691. > +-- FIXME: test is disabled for LuaJIT. > prepfile("#comment with a binary = file\n"..string.dump(loadstring("print(1)"))) > -RUN("lua %s > %s", prog, out) > -checkout("1\n") > +-- RUN("lua %s > %s", prog, out) > +-- checkout("1\n") >=20 > prepfile("#comment with a binary = file\r\n"..string.dump(loadstring("print(1)"))) > -RUN("lua %s > %s", prog, out) > -checkout("1\n") > +-- Behavior is different for LuaJIT. See the comment above. > +-- FIXME: test is disabled for LuaJIT. > +-- RUN("lua %s > %s", prog, out) > +-- checkout("1\n") >=20 > -- close Lua with an open file > prepfile(string.format([[io.output(%q); io.write('alo')]], out)) > --=20 > 2.31.0 >=20