From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [tarantool-patches] Re: [PATCH v2] replication: do not ignore replication_connect_quorum. From: Serge Petrenko In-Reply-To: <20180809122011.azcmyh5qnuipm3uh@esperanza> Date: Thu, 9 Aug 2018 15:39:26 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <2DC61B5A-36F2-4F4B-8190-FD09E5BD9F50@tarantool.org> References: <20180807124413.14947-1-sergepetrenko@tarantool.org> <20180807172847.z7h7476jedxktwno@esperanza> <34F1BCA9-2C61-4C3A-939D-F90E745B349D@tarantool.org> <20180809091101.hzsxrym3zgndgmgz@esperanza> <20180809122011.azcmyh5qnuipm3uh@esperanza> To: Vladimir Davydov Cc: Georgy Kirichenko , tarantool-patches@freelists.org List-ID: > 9 =D0=B0=D0=B2=D0=B3. 2018 =D0=B3., =D0=B2 15:20, Vladimir Davydov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 > On Thu, Aug 09, 2018 at 12:11:01PM +0300, Vladimir Davydov wrote: >>>>> diff --git a/test/replication-py/master.lua = b/test/replication-py/master.lua >>>>> index 0f9f7a6f0..51283efdf 100644 >>>>> --- a/test/replication-py/master.lua >>>>> +++ b/test/replication-py/master.lua >>>>> @@ -3,6 +3,8 @@ os =3D require('os') >>>>> box.cfg({ >>>>> listen =3D os.getenv("LISTEN"), >>>>> memtx_memory =3D 107374182, >>>>> + replication_connect_timeout =3D 1.0, >>>>> + replication_timeout =3D 0.3 >>>>=20 >>>> Why do you need to adjust the timeouts? >>>=20 >>> The timeouts set in all cfg files in all the tests had no effect, = just like the >>> replication_connect_quorum option, cos both of the options were = ignored >>> During bootstrap. We wanted every replica to connect, and the = timeout was >>> Set to TIMEOUT_INFINITY. Now when we actually start passing >>> replication_connect_timeout, all these timeouts become too small. >>=20 >> Some tests now take too long because of this. E.g. replication/quorum >> runs for 15 seconds for memtx+vinyl without this patch, which is = already >> long enough, but with this patch it takes more than 30 seconds. We = need >> to do something about that. >=20 > May be, we could pass replication_connect_timeout to these scripts > in arguments and use different timeouts for bootstrap and subsequent > restarts? >=20 Yeah, this makes sense. Will try. I tried to fix replication/quorum, but could only decrease the time to 22 seconds on memtx + vinyl, and the test wasn=E2=80=99= t stable.=