From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8F547210AE for ; Wed, 24 Jul 2019 13:44:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7ck7MPLcdXIL for ; Wed, 24 Jul 2019 13:44:36 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4E3F7208F2 for ; Wed, 24 Jul 2019 13:44:36 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding From: "n.pettik" In-Reply-To: <20190724171007.GB4764@atlas> Date: Wed, 24 Jul 2019 20:44:34 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <2D87D431-5106-4599-8AB9-ABFD66B99EA2@tarantool.org> References: <20190724165508.81356-1-korablev@tarantool.org> <20190724171007.GB4764@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Konstantin Osipov > On 24 Jul 2019, at 20:10, Konstantin Osipov = wrote: >=20 > * Nikita Pettik [19/07/24 19:59]: >> It was decided that for all integer literals we would return = "INTEGER" >> type, not "UNSIGNED". Accidentally, after substitution of unsigned >> binding value type was set to "UNSIGNED". Let's fix that and set >> "INTEGER" type. >=20 > the patch is lgtm but I'm not sure it covers all cases. >=20 > I've seen a lot of unsigned inthe tests. I see only one more unsigned appearance: box.execute("SELECT CAST('123' AS UNSIGNED);") --- - metadata: - name: CAST('123' AS UNSIGNED) type: unsigned rows: - [123] =E2=80=A6 But I guess in this case user would be less surprised if one saw unsigned type than integer. > --=20 > Konstantin Osipov, Moscow, Russia