From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D6FF96F3C7; Fri, 26 Mar 2021 19:28:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D6FF96F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616776088; bh=jm1elPFeK7fnWXEuTHjEBpAPZ4k7Rk4hkpU7BXBNVoQ=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=shNFoKlAjDBPW3BX+9JmielMYb4PYfRmrVuM9erWxg7JXPu3v+/mMTQdkyri2ya2/ nTicVLW1NeTc/zuANSrRCzoBe0hO5jPSw9srxv7ikqN3giPquTnSRV0UAC7REk/v/p IAtJ3+QuOsveFbC/b5G8+3kTqrTGtYsK5Nj5PyOA= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 452596F3C7 for ; Fri, 26 Mar 2021 19:28:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 452596F3C7 Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1lPpJe-0002uy-BG; Fri, 26 Mar 2021 19:28:06 +0300 Message-Id: <2CF6AD3A-89CD-4599-A108-7D801D4F4B2F@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_57CA3BD5-E5AF-4482-AE4C-8F8CE9A3E34E" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 26 Mar 2021 19:28:05 +0300 In-Reply-To: <0e928a814f30027c58bcd7b6e587f811ed5a6dfc.1616743343.git.skaplun@tarantool.org> To: Sergey Kaplun References: <0e928a814f30027c58bcd7b6e587f811ed5a6dfc.1616743343.git.skaplun@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F5380850401E1CB1AD571AD64C00E061F1B3D879597F69A9F46EEDEB83F7FAC471D6385158 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C4470ABEE4BC4B50EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DA5CEC9EE7F170198638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DC86B1FF70DFC4CA5F35017B30274CECEA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF40B429B92CE9FF2BBA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6BD8D6CC6D5691A2276E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C3A1C30C8AFC676C8B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831A31D1922CB5992DDC527CFD643BC0A42 X-C1DE0DAB: 0D63561A33F958A5B2B6D8615891F36802E7AB8F8EE9C118BD5D8A95FE8E1D45D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E28EA3025147C39D6EF5952154207A1AF290B4B66E5A2F9CFC52616250023AC07C1D7E09C32AA3244CB3A87B87202AF34A740E4F2447D1D90530363D8B7DA7DD44FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAiQqEXlPct+Mg== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC0483962FF1C3409DBE8E21FA7E3871744DDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 30/30] test: disable too depth recursive PUC Lua test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_57CA3BD5-E5AF-4482-AE4C-8F8CE9A3E34E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Did you look into the fiber_new_ex() interface? I bet it=E2=80=99s doable to create a fiber with big enough stack. Again, not about follow-ups: LGTM. Sergos > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: >=20 > The first Tarantool's fiber has only 512Kb of stack. > It is not enough for depth recursive call in the test for > `string.gsub()`. >=20 > This patch disables test leads to Tarantool crash. >=20 > Relates to tarantool/tarantool#5782 > Resolves tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/pm.lua | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/pm.lua = b/test/PUC-Lua-5.1-tests/pm.lua > index b159b6b..c6e42df 100644 > --- a/test/PUC-Lua-5.1-tests/pm.lua > +++ b/test/PUC-Lua-5.1-tests/pm.lua > @@ -207,7 +207,11 @@ function rev (s) > end >=20 > local x =3D string.rep('012345', 10) > -assert(rev(rev(x)) =3D=3D x) > +-- The first Tarantool's fiber has only 512Kb of stack. > +-- It is not enough for this recursive call. > +-- See also https://github.com/tarantool/tarantool/issues/5782. > +-- FIXME: The test is disabled for Tarantool binary. > +-- assert(rev(rev(x)) =3D=3D x) >=20 >=20 > -- gsub with tables > --=20 > 2.31.0 >=20 --Apple-Mail=_57CA3BD5-E5AF-4482-AE4C-8F8CE9A3E34E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Did = you look into the fiber_new_ex() interface?
I bet it=E2=80=99s= doable to create a fiber with big enough = stack.

Again, not about follow-ups: = LGTM.
Sergos


On 26 Mar 2021, at 10:43, = Sergey Kaplun <skaplun@tarantool.org> wrote:

The = first Tarantool's fiber has only 512Kb of stack.
It is not = enough for depth recursive call in the test for
`string.gsub()`.

This patch = disables test leads to Tarantool crash.

Relates to tarantool/tarantool#5782
Resolves = tarantool/tarantool#5845
Part of = tarantool/tarantool#4473
---
= test/PUC-Lua-5.1-tests/pm.lua | 6 +++++-
1 file changed, = 5 insertions(+), 1 deletion(-)

diff --git = a/test/PUC-Lua-5.1-tests/pm.lua b/test/PUC-Lua-5.1-tests/pm.lua
index b159b6b..c6e42df 100644
--- = a/test/PUC-Lua-5.1-tests/pm.lua
+++ = b/test/PUC-Lua-5.1-tests/pm.lua
@@ -207,7 +207,11 @@ = function rev (s)
end

local = x =3D string.rep('012345', 10)
-assert(rev(rev(x)) =3D=3D = x)
+-- The first Tarantool's fiber has only 512Kb of = stack.
+-- It is not enough for this recursive call.
+-- See also https://github.com/tarantool/tarantool/issues/5782.
+-- FIXME: The test is disabled for Tarantool binary.
+-- assert(rev(rev(x)) =3D=3D x)


-- gsub with tables
--
2.31.0


= --Apple-Mail=_57CA3BD5-E5AF-4482-AE4C-8F8CE9A3E34E--