From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2E6A026C20 for ; Thu, 7 Feb 2019 13:52:47 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k2mwl_dEgOeA for ; Thu, 7 Feb 2019 13:52:47 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E213B266E6 for ; Thu, 7 Feb 2019 13:52:46 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove tests on stmts with 'db table' From: "n.pettik" In-Reply-To: <20190207181742.85150-1-ivan.koptelov@tarantool.org> Date: Thu, 7 Feb 2019 21:52:43 +0300 Content-Transfer-Encoding: 7bit Message-Id: <2B6FCFC5-F098-4E97-98D8-7E052D77E842@tarantool.org> References: <20190207181742.85150-1-ivan.koptelov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Ivan Koptelov > On 7 Feb 2019, at 21:17, Ivan Koptelov wrote: > > We don't have such functionality, but some legacy tests were > existed (disabled). Do you checked all test files, or only e_delete.test.lua? If the latter is the case, mention it in commit message/subject. AFAIR we had a lot of similar tests in our test suite; I am not sure about current status of such tests. Otherwise, it sounds like you cleaned up all our test suite. Then LGTM.