From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 72D85259F7 for ; Fri, 18 May 2018 13:04:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8VJTNuJ0wnnT for ; Fri, 18 May 2018 13:04:36 -0400 (EDT) Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 26965259EE for ; Fri, 18 May 2018 13:04:35 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v6 3/4] sql: space_def* instead of Table* in Expr From: "n.pettik" In-Reply-To: <23e5e1f9-3700-26b4-c974-1b0379dc9bcb@tarantool.org> Date: Fri, 18 May 2018 20:04:26 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <2B2A74BE-9817-4296-B7EA-DFE1A1AFD8F3@tarantool.org> References: <6702e8ecd47238730a4ba27e87fe7bf082a874c6.1526403792.git.kshcherbatov@tarantool.org> <26E4269B-2BCB-42C3-8216-D51E290E4723@corp.mail.ru> <23e5e1f9-3700-26b4-c974-1b0379dc9bcb@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov >> Probably, you have missed some word (=E2=80=98use=E2=80=99, = =E2=80=98replace=E2=80=99 or whatever) >>=20 >> Sorry, but I can=E2=80=99t parse this commit message. Lets dive a = little bit into details >> and explain what this patch *really* does. Such as: >> =E2=80=9CMove affinity filed to struct field in order to bla-bla=E2=80=9D= . >>=20 >> The rest is almost okay, a few minor remarks. > ``` > sql: space_def* instead of Table* in Expr This message still lacks a verb. Such as: sql: use space_def* instead Table* in Expr OR sql: replace Table* with space_def* in Expr >=20 > Changed Table pointer to space_def in Expr structure. > This makes able to resolve self reference in DDL before I guess, you lost =E2=80=99t=E2=80=99 or smth else.. >> Wait, why did you delete assert which had been introduced in the = previous patch? > Because I've changed func. prototype. Well, I mean anyway these patches come together, so it makes no sense to fix code (especially asserts) introduced in n-th commit by code in = (n+1)-th - it is just redundant diff (in most cases).