From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E046F2BBB4 for ; Thu, 11 Apr 2019 12:56:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZvoUwVCrcGG5 for ; Thu, 11 Apr 2019 12:56:33 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 96AE42BBB0 for ; Thu, 11 Apr 2019 12:56:33 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: remove unused macros in SQL References: <7654181f806322478e4de2b4c9c800fd5fa33077.1554830037.git.imeevma@gmail.com> From: Imeev Mergen Message-ID: <29f798a5-3487-0723-0219-6648897d98c6@tarantool.org> Date: Thu, 11 Apr 2019 19:56:31 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org Hi! Thank you for review! My answers below. On 4/11/19 3:08 AM, n.pettik wrote: > >> On 9 Apr 2019, at 20:17, imeevma@tarantool.org wrote: >> >> Thise macros unused and should be removed. > Nit: these. > > Nit: are unused. Thanks, will fix. > > Are you sure that you’ve removed *all* unused macros? > Otherwise, which attribute are you used to spot this group > of macros? Definitely not all. I started with main.c. Should I remove all unused macros or just add to the commit-message that these macros are from main.c?