From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 61A5527F6C for ; Thu, 29 Mar 2018 04:23:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XG2Z_83gTPdU for ; Thu, 29 Mar 2018 04:23:46 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 128D027F35 for ; Thu, 29 Mar 2018 04:23:45 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: Fwd: [patches] [log 2/2] say: Fix log_rotate Date: Thu, 29 Mar 2018 11:23:37 +0300 Message-ID: <2949639.NBXie4y127@home.lan> In-Reply-To: <1522224370.984371501@f506.i.mail.ru> References: <1522224370.984371501@f506.i.mail.ru> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12381647.ssYixlB1hb"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Ilya Markov --nextPart12381647.ssYixlB1hb Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Please sent all messages bounded as a tree. A cover message should include issue description See some comment bellow. On Wednesday, March 28, 2018 11:06:10 AM MSK Ilya Markov wrote: > - if (log->type != SAY_LOGGER_FILE) { > + if (pm_atomic_load(&log->type) != SAY_LOGGER_FILE) > return 0; I am not sure you really need to use atomic. What the case you are trying to fix? --nextPart12381647.ssYixlB1hb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBJFDbU76LsBbgHBsvKOmCX79zb4FAlq8ookACgkQvKOmCX79 zb4fugf/Qofri+Su3URnxGrhhfDEXbnw8IuaDb3d1hi87OwJwfQRlDgtX7Pcz6ox 8ie7t1X2AfNt9d7JqWFOwXcn/1CCH5qEsVpV5iT6n3Q7nPDn5KAt5JKrx0GwOFBH b69JoSLlVjENY2LKIISdixJ/1La/xnP4Fey8asK/IHvnt3OERkNPWdAIzqzwixRE 6MJV+3FpVrC3hjFvJjDXYebBP+5vHtznE3Sk77uVPfEwnZvYpfC1dtRYgt38x8Jq pSw9P2NeeKlpj1q1vEvAMdaztTgeiT4b9CCvw21ZhHWy2Wsz6BIRvQfVZtNAnhzj prkMzT1asH0+gO9DQ5CtmPfqSp3fQg== =WBd5 -----END PGP SIGNATURE----- --nextPart12381647.ssYixlB1hb--