From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <georgy@tarantool.org>
From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= <georgy@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v4 3/9] txn: get rid of autocommit from a txn structure
Date: Thu, 20 Jun 2019 23:16:41 +0300
Message-ID: <29461295.AVA2JscLMl@home.lan>
In-Reply-To: <20190620115221.ns5jsvhn3xk6khsd@esperanza>
References: <cover.1560978655.git.georgy@tarantool.org> <318da5c367be4c0cfcbc049d50ec619672ac5629.1560978655.git.georgy@tarantool.org> <20190620115221.ns5jsvhn3xk6khsd@esperanza>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart9354974.rFM00oWent"; micalg="pgp-sha256"; protocol="application/pgp-signature"
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

--nextPart9354974.rFM00oWent
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday, June 20, 2019 2:52:21 PM MSK Vladimir Davydov wrote:
> On Thu, Jun 20, 2019 at 12:23:10AM +0300, Georgy Kirichenko wrote:
> > @@ -1313,9 +1351,17 @@ box_sequence_reset(uint32_t seq_id)
> > 
> >  static inline void
> >  box_register_replica(uint32_t id, const struct tt_uuid *uuid)
> >  {
> > 
> > +	struct txn *txn = txn_begin();
> > +	if (txn == NULL)
> > +		diag_raise();
> > 
> >  	if (boxk(IPROTO_INSERT, BOX_CLUSTER_ID, "[%u%s]",
> > 
> > -		 (unsigned) id, tt_uuid_str(uuid)) != 0)
> > +		 (unsigned) id, tt_uuid_str(uuid)) != 0) {
> > +		txn_rollback();
> > 
> >  		diag_raise();
> > 
> > +	}
> > +	if (txn_commit(txn) != 0)
> > +		diag_raise();
> > +	fiber_gc();
> > 
> >  	assert(replica_by_uuid(uuid)->id == id);
> >  
> >  }
> 
> It looks like you didn't addressed any of my comments to v3,
> neither did you reply to the email:
Oh, sorry, I forgot this one
> 
>  
> https://www.freelists.org/post/tarantool-patches/PATCH-v3-0514-txn-get-rid-> of-autocommit-from-a-txn-structure,1


--nextPart9354974.rFM00oWent
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAl0L6akACgkQFSyY70x8
X3sV0Qf9FHKQ7LGGK90AHsX+zblNf7exjC1aPP9vTdf38VfyyBk+GepdM2z2XUNh
lNcugNbXEc0sTjScgyXrAGQAJ0OPgB3405R06amzsChUmht/u3vy1sTXoi54bDbD
KyL9CJxFEIwG+CsrAwtqDzKCbmlmzQjP8Vpg5U6NDYAmnarHEAOQW/u3uUZS0ARC
trWGT3LBG3nle75bGPEmaXvIL4Aj+Liub3Z06D4g1WAuO2TwreXkM40ZJakbIIeB
VfZgiJbf/MMyRyZDqQ5EVV/e536DMJqjpWYw0YIC24+BoQwKDA83nupMPI21/mqN
YetXcuY9bcnm0OfvpUZOD+Y3WIkVcA==
=IGuj
-----END PGP SIGNATURE-----

--nextPart9354974.rFM00oWent--