Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: define default types for built-in functions
Date: Mon, 15 Nov 2021 22:53:25 +0100	[thread overview]
Message-ID: <28f2d8fb-af9a-9a9f-023f-6295c118d2d6@tarantool.org> (raw)
In-Reply-To: <abd741469c235c008e7e1a2da0ab7319ce7f15b7.1636717230.git.imeevma@gmail.com>

Thanks for the patch!

> +test:do_test(
> +    "builtins-4.6",
> +    function()
> +        local res = {pcall(box.execute, [[SELECT LENGTH(?);]], {1})}
> +        return {tostring(res[3])}

Don't we usually use do_catchsql_test for such tests? The same for
4.9, 4.13, 4.14.

  reply	other threads:[~2021-11-15 21:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 11:41 Mergen Imeev via Tarantool-patches
2021-11-15 21:53 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-11-19  8:15   ` Mergen Imeev via Tarantool-patches
2021-11-21 15:23     ` Vladislav Shpilevoy via Tarantool-patches
2021-11-22  7:43 Mergen Imeev via Tarantool-patches
2021-11-22 12:32 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28f2d8fb-af9a-9a9f-023f-6295c118d2d6@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: define default types for built-in functions' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox