From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/5] Split vote and bugs
Date: Tue, 25 Jan 2022 13:18:05 +0300 [thread overview]
Message-ID: <28ee7510-8379-a1e7-7f3d-e5c4d132e528@tarantool.org> (raw)
In-Reply-To: <cover.1642639079.git.v.shpilevoy@tarantool.org>
20.01.2022 03:43, Vladislav Shpilevoy пишет:
> Split vote handling in Raft, its usage in storage, and 2 bug fixes found while
> working on this.
>
> Changes in v2:
> - dropped ev_timer.at usage;
> - disabled split-vote detection for cluster < quorum;
> - disabled split-vote for vote count > cluster;
> - re-checked split vote after WAL write;
> - re-checked split vote on quorum change.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5285-raft-split-vote
> Issue: https://github.com/tarantool/tarantool/issues/5285
>
> Vladislav Shpilevoy (5):
> raft: fix crash on election_timeout reconfig
> raft: fix ev_timer.at incorrect usage
> raft: track all votes, even not own
> raft: introduce split vote detection
> election: activate raft split vote handling
>
> .../unreleased/election-timeout-cfg-crash.md | 5 +
> src/box/raft.c | 4 +-
> src/lib/fakesys/fakeev.c | 10 +-
> src/lib/raft/raft.c | 222 ++++++++--
> src/lib/raft/raft.h | 32 +-
> .../election_split_vote_test.lua | 92 ++++
> test/unit/raft.c | 393 +++++++++++++++++-
> test/unit/raft.result | 87 +++-
> test/unit/raft_test_utils.c | 12 +
> test/unit/raft_test_utils.h | 5 +
> 10 files changed, 803 insertions(+), 59 deletions(-)
> create mode 100644 changelogs/unreleased/election-timeout-cfg-crash.md
> create mode 100644 test/replication-luatest/election_split_vote_test.lua
>
LGTM. Thanks!
--
Serge Petrenko
next prev parent reply other threads:[~2022-01-25 10:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 0:43 Vladislav Shpilevoy via Tarantool-patches
2022-01-20 0:43 ` [Tarantool-patches] [PATCH v2 1/5] raft: fix crash on election_timeout reconfig Vladislav Shpilevoy via Tarantool-patches
2022-01-20 0:43 ` [Tarantool-patches] [PATCH v2 2/5] raft: fix ev_timer.at incorrect usage Vladislav Shpilevoy via Tarantool-patches
2022-01-20 0:43 ` [Tarantool-patches] [PATCH v2 3/5] raft: track all votes, even not own Vladislav Shpilevoy via Tarantool-patches
2022-01-20 0:43 ` [Tarantool-patches] [PATCH v2 4/5] raft: introduce split vote detection Vladislav Shpilevoy via Tarantool-patches
2022-01-20 13:22 ` Serge Petrenko via Tarantool-patches
2022-01-20 23:02 ` Vladislav Shpilevoy via Tarantool-patches
2022-01-25 10:17 ` Serge Petrenko via Tarantool-patches
2022-01-20 0:43 ` [Tarantool-patches] [PATCH v2 5/5] election: activate raft split vote handling Vladislav Shpilevoy via Tarantool-patches
2022-01-25 10:18 ` Serge Petrenko via Tarantool-patches [this message]
2022-01-25 22:51 ` [Tarantool-patches] [PATCH v2 0/5] Split vote and bugs Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ee7510-8379-a1e7-7f3d-e5c4d132e528@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/5] Split vote and bugs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox