From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1BDB728980 for ; Mon, 13 Aug 2018 16:24:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I_S-S3igKTPB for ; Mon, 13 Aug 2018 16:24:33 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C4037287E1 for ; Mon, 13 Aug 2018 16:24:32 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 04/10] sql: remove flags from struct Table References: <2e3030fa0e25bad36c4d847babff2be4d6ff2c69.1534001739.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: <2861589c-7ee6-ad5a-26bf-150b1da6f84f@tarantool.org> Date: Mon, 13 Aug 2018 23:24:31 +0300 MIME-Version: 1.0 In-Reply-To: <2e3030fa0e25bad36c4d847babff2be4d6ff2c69.1534001739.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! I have pushed my review fixes in a separate commit. On 12/08/2018 17:13, Nikita Pettik wrote: > Check on flag TF_HasPrimaryKey replaced with simple PK lookup in the > list of table indexes. > Check on flag TF_Ephemeral replaced with table->def->id == 0. > Check on flag TF_Autoincrement replaced with table->iAutoinc >= 0. > > Part of #3561 > --- > src/box/sql/build.c | 11 ++++------- > src/box/sql/insert.c | 12 ++++-------- > src/box/sql/select.c | 4 +--- > src/box/sql/sqliteInt.h | 8 -------- > src/box/sql/where.c | 3 +-- > 5 files changed, 10 insertions(+), 28 deletions(-) >