From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D63506BD02; Tue, 30 Mar 2021 02:06:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D63506BD02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617059179; bh=meY8I62nmLfYOXzHLdN5Q5pBFi5rMBmKJDl6CfmU4UY=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dYK8ejAV/LZT6iltKtTSMHBj4ydeu9F/O+pxwI6c2LvXF/lf5QUFav3L+SBHuvWOC zN4PfLLToRa3W5EGc7xbJ11vrl3+Xl/MS1T0kEf3wF9abt7/qTZDfeydzpiiNiqxAU /9BF0fJxlrW2lAP8/qm2w7ha5V7gJe/FcqQuQ5mI= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 767246BD07 for ; Tue, 30 Mar 2021 02:04:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 767246BD07 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lR0w6-0001OE-Ng; Tue, 30 Mar 2021 02:04:43 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <281bf39e-c376-5850-6777-1c3d9c01b8dd@tarantool.org> Date: Tue, 30 Mar 2021 01:04:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F5380850407D7EC525FA4064990307F2831602B125F04A67E3C2944B908BE7A1743F8931E8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFA8356B31CDFC1CC7242D8997EBE3B129A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C301200A96CB7104FF117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F409322A2F59C95CC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831B61D915BCC9FD1C9E6846C195B0237D3 X-C1DE0DAB: 0D63561A33F958A5D0D204D13616B912FF2EA30FCF7A9B9CFDDFB356F49CB1F7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A150564C13026C186B0AC7C02AFDD0C5248976B511A9DBD8E63BBF72A24F0C6DA817C590CD3128321D7E09C32AA3244CB6CB31BA301E92AC87204D2D13FAACEE7C0C08F7987826B9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rSh/J4MCWlHDQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382251D4D9BA38AB274E4D4D6C60BB81C49F3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 27/53] sql: refactor mem_set_double() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! See 2 comments below. On 23.03.2021 10:35, Mergen Imeev via Tarantool-patches wrote: > This patch introduces mem_set_double(). Function mem_set_double() > clears MEM and sets it to given unsigned value. 1. It is not about unsigned. > Part of #5818 > --- > diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h > index bf3690b7c..49b4e4b1a 100644 > --- a/src/box/sql/mem.h > +++ b/src/box/sql/mem.h > @@ -419,10 +422,6 @@ int sqlVdbeMemClearAndResize(struct Mem * pMem, int n); > void > mem_set_ptr(struct Mem *mem, void *ptr); > > -/** Set double value and MEM_Real flag. */ > -void > -mem_set_double(struct Mem *mem, double value); 2. Why do you move these functions and their definitions? What was wrong with keeping them in place? > - > int > sqlVdbeMemSetStr(struct Mem *, const char *, int, u8, void (*)(void *)); > void >