From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 040186EC40; Thu, 19 Aug 2021 14:11:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 040186EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629371499; bh=uNTNXCR6nZAUeVx3X0sDSgAYtsvSFw/obo/oxw7Sb/M=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AL9bXefJHmh/IacX5NZp2I3dNf0CMpms4cxJ/Wko0Wk4w/1qhatsKJhSsd9WwN5OU 0WfFk2c7wUQM383VCYvpNEO0cPZzNK12wCIktYUHQnb6Ngbvak5I6PWxJyNNTIYkH7 anulBxDgdvCy+RdzME8m8Rv6HXi0itWIQpJzVzWc= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A5BB6EC40 for ; Thu, 19 Aug 2021 14:11:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A5BB6EC40 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1mGfxQ-0008NC-0e; Thu, 19 Aug 2021 14:11:36 +0300 To: Safin Timur , vdavydov@tarantool.org, tarantool-patches@dev.tarantool.org References: <82319534-df35-ceb6-ee22-cb4cbaff5e41@tarantool.org> Message-ID: <27cf13a8-5ef8-536e-8e17-fb5e78078a41@tarantool.org> Date: Thu, 19 Aug 2021 14:11:35 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9736CF3E71F18CE0C3E1D5927724F4AAA182A05F5380850405A1A7BFB8492BDB96DB28FB0237CBF6561094EAD5B384E2948F92316039AC5CF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750965CC5CDB672DE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89062E8CA845B9AFF50E16FF155FF4C51117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A9A04DE7321024275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5F948B7158A095B5EE7EC764AF3654C2A17FE19A4E2DA0137D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758B25CD4253D1D611410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34060C3C6DE316ECE464DF02884E92D5685162D2B8ED76C9E13EED53503A6643F8B6144CF0E89F5A201D7E09C32AA3244CC1DCC237C994C72C793A23A064D21F67A995755A1445935EDCA3B3C10BC03908 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBHLQlPRgKsUSg== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4466DC9272EFCD81FDDB49FF9AE584D6884976AF1CB91E68C81424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 4/5] datetime: perf test for datetime parser X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: v.shpilevoy@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 19.08.2021 13:29, Safin Timur пишет: > On 19.08.2021 13:19, Serge Petrenko wrote: >> >> >> 19.08.2021 05:56, Timur Safin пишет: >>> It was told that if field `datetime.secs` would be `double` we >>> should get >>> better performance in LuaJIT instead of `uint64_t` type, which is >>> used at the >>> moment. >>> >>> So we have created benchmark, which was comparing implementations of >>> functions >>> from `datetime.c` if we would use `double` or `int64_t` for >>> `datetime.secs` field. >>> >>> Despite expectations, based on prior experience with floaing-point >>> on x86 >>> processors, comparison shows that `double` provides similar or >>> sometimes better timings. And picture stays consistent be it SSE2, >>> AVX1 or >>> AVX2 code. >>> >>> Part of #5941 >>> --- >> >> I agree with Vladimir here. >> Looks like this perf test doesn't belong to Tarantool repository. >> Would you mind dropping it? > > Here is the case (we both aware of) I want to avoid here - today we do > not have saved _that_ decimal perf test, basing on which we have > preferred LuaC and dropped FFI implementation. We could not rerun it > today, within a newer LuaJIT implementation, to verify that situation > didn't change. This is similar case - we have made a decision basing > on some evaluations using this code, in a future we may decide to > further optimize data structure (like Vova suggested elsewhere to > split int64 into 2 fields), and it would be better if at that moment > we would still have performance test around for adaptations and rerun. > > Yes, it's another test of performance test we used to see in perf > directory (hehe, there is only single test at the moment), kind of one > time shot in a history, important for design decision, but from longer > prospective I assume it should be still around. > > Does my reasoning make some sense? Yes, I see your point. But you've saved the test in some github discussion, AFAIR. I feel like it's an ok place to save it. If you really want to save the test in this repo, maybe introduce a new folder? Since perf/ is really intended to store perf tests. Not the ones that have influenced this or that decision, but the ones that should be run every now and then to find regressions. > > Thanks, > Timur -- Serge Petrenko