From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 994AA27881
	for <tarantool-patches@freelists.org>; Thu, 22 Aug 2019 04:59:25 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id aFKi5k4CXchq for <tarantool-patches@freelists.org>;
	Thu, 22 Aug 2019 04:59:25 -0400 (EDT)
Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 27831260A1
	for <tarantool-patches@freelists.org>; Thu, 22 Aug 2019 04:59:25 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET
 on macOS
References: <20190819082813.38237-1-m.melentiev@corp.mail.ru>
 <20190819193333.z525sey6oe2dbnvg@tkn_work_nb>
 <28f95bdb-d3c7-6d70-7af8-2e40b62cf9c7@corp.mail.ru>
 <20190821155200.GA7926@atlas>
From: "Maxim Melentiev" <dmarc-noreply@freelists.org> (Redacted sender
 "m.melentiev" for DMARC)
Message-ID: <27beb551-6221-6e7e-5bba-61802782fe41@corp.mail.ru>
Date: Thu, 22 Aug 2019 11:59:22 +0300
MIME-Version: 1.0
In-Reply-To: <20190821155200.GA7926@atlas>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, alexander.turenko@tarantool.org

Does this work as you expect? Is there any reason to expose 
HAVE_MSG_NOSIGNAL to C code?

option(WITH_NOTIFY_SOCKET "Enable notifications on NOTIFY_SOCKET" ON)

if (WITH_SYSTEMD AND NOT WITH_NOTIFY_SOCKET)
     message(FATAL_ERROR "WITH_NOTIFY_SOCKET must be enabled when 
WITH_SYSTEMD enabled")
endif()

if (WITH_NOTIFY_SOCKET)
     # Linux supports MSG_NOSIGNAL flag for sendmsg.
     # macOS lacks it, but has SO_NOSIGPIPE for setsockopt
     # to achieve same behavior.
     CHECK_C_SOURCE_COMPILES("
         #include <sys/types.h>
         #include <sys/socket.h>
         int main(){ return MSG_NOSIGNAL; }
     " HAVE_MSG_NOSIGNAL)
     CHECK_C_SOURCE_COMPILES("
         #include <sys/types.h>
         #include <sys/socket.h>
         int main(){ return SO_NOSIGPIPE; }
     " HAVE_SO_NOSIGPIPE)
     if (NOT HAVE_MSG_NOSIGNAL AND NOT HAVE_SO_NOSIGPIPE)
         message(FATAL_ERROR
             "No way to block SIGPIPE in sendmsg. Can not compile with 
WITH_NOTIFY_SOCKET"
         )
     endif()
endif()

And C code uses #ifdef SO_NOSIGPIP, #ifdef MSG_NOSIGNAL

On 21/08/2019 18:52, Konstantin Osipov wrote:
> * Maxim Melentiev <m.melentiev@corp.mail.ru> [19/08/21 11:32]:
>
> this doesn't address my review.
>
> If you disagree with the review, please reply to it. Otherwise
> there is no point in sending a new patch.
>