From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 881246EC55; Mon, 26 Jul 2021 23:27:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 881246EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627331234; bh=vOMvJH50XjNmayqljhpN7VJ4XD4h4ldJ0CzHnXcazeU=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zG68bjBGG6X/ylfogNaO9hZaVMTuCDfJxixHzQAX7q8Sp59t9WJ9fGBeXLrt+MYNv CvkDK0H2uRvRdiA8qX6hTp255ZLmiSKrY6XaOER0yIsZQF2Zn9pI5hwvqg7VuRuYfq bqOd7KLuwqgHA55IcipJ3sQAkia8OK2hT+AWXjcQ= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 709D96EC55 for ; Mon, 26 Jul 2021 23:27:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 709D96EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m87Bv-0001V0-NP; Mon, 26 Jul 2021 23:27:12 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <20210722072002.13145-1-sergepetrenko@tarantool.org> Message-ID: <27aaa450-7c0c-1e5e-e912-db5bae282e16@tarantool.org> Date: Mon, 26 Jul 2021 22:27:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210722072002.13145-1-sergepetrenko@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F538085040C001CB6D32BF1531D2DCDB4D50BAA8B8E4172D394D33B341C2D3930A75729E48 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73DF5CE93DF87A85BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF20B9B7F5DD35A68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8754A3DE9EA207A0A93DBB7C729D33A87117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50566D5D5C7453E9A2245CD0ED175473416 X-C1DE0DAB: 0D63561A33F958A5FF48FA1C3A39F6377807EC2CEBA3410B172785A1ED308D33D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7517A45118377F5F9E8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3451BBE684D17D722169EC718632336B5F6DD0D31C6255A6016BA80E393708365F44DB56CB478FD7481D7E09C32AA3244CE11B74116AD69A2849CFE2AB152DDD4451E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5/oFqCd3ipxZg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D47B9FF92C4CAE958670DDC382F8628C23841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] box: introduce on_election triggers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! See 3 comments below. > diff --git a/src/box/raft.c b/src/box/raft.c > index 7f787c0c5..c9c3ba818 100644 > --- a/src/box/raft.c > +++ b/src/box/raft.c > @@ -52,6 +52,8 @@ enum election_mode box_election_mode = ELECTION_MODE_INVALID; > */ > static struct trigger box_raft_on_update; > > +struct rlist box_raft_on_state = RLIST_HEAD_INITIALIZER(box_raft_on_state); 1. I propose to call it 'box_raft_on_update'. We usually use 'on_' naming pattern. > + > /** > * Worker fiber does all the asynchronous work, which may need yields and can be > * long. These are WAL writes, network broadcasts. That allows not to block the > @@ -274,6 +276,7 @@ box_raft_broadcast(struct raft *raft, const struct raft_msg *msg) > assert(raft == box_raft()); > struct raft_request req; > box_raft_msg_to_request(msg, &req); > + trigger_run(&box_raft_on_state, NULL); 2. Maybe call it after the state is pushed to the relays? So as it would be sent earlier in case the triggers are going to yield. > replicaset_foreach(replica) > relay_push_raft(replica->relay, &req); > } > diff --git a/test/replication/gh-5819-election-triggers.result b/test/replication/gh-5819-election-triggers.result > new file mode 100644 > index 000000000..546aac8a2 > --- /dev/null > +++ b/test/replication/gh-5819-election-triggers.result 3. Hm, I think we are supposed to use gh-#### file naming only for bugfixes. https://github.com/tarantool/tarantool/wiki/Code-review-procedure#testing This is a feature, hence can have a normal name, or be in an existing test file which is also not bound to a single ticket.