From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1495B6F153; Fri, 2 Sep 2022 15:06:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1495B6F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1662120408; bh=VqpmkUdu2BQeW/a3znJy4M7NPfZ7MAd+9Vca/vXCJk8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZeZNFCuNNtIo0TtywUi6sshiWuSuJeiivCgUHsz96VZ+xw7oeAMxtWKVgz6DSSFLY q4n3KYdwrOKczFXrxNOI2vG9B0RYo9tPZvNosJbflhvu8Pn8iUgY7I8Y1zVD6KFCBR dDJYYnxJIGkWQDuGavjSbaXyHQ95KU7v4oauXvyg= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7CB106F153 for ; Fri, 2 Sep 2022 15:06:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7CB106F153 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1oU5Rb-0001i9-K0; Fri, 02 Sep 2022 15:06:44 +0300 Message-ID: <2771fb73-973b-3dd6-ef87-881f31dcda96@tarantool.org> Date: Fri, 2 Sep 2022 15:06:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Igor Munkin References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9029AF47137F508F1CDC76D163DB14259D29D17E9300A11A400894C459B0CD1B98456A244A3079C39BC813F2B41CD0180F784538C60389670EEF59CA297A41560 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637593B4F2A76947A308638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D844ADAB7D57A714D700058E36F99B0AD3117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B1BE95B8C87527B4BA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCA26C8913F777CCC43AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006375BCAB1AE60D7639FD81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F6736582285900E6157739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0D4C601CEA03E70EE7CE36540D89DA4342F1682D4284D75D9FE8351279BA8557B9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37EB136E3BE089A06955D616F8FFB27D9342C944BBE1C777A44DD66FD289DB2434F1D7E09C32AA3244C8510BE501AC2F43F39088463D9AF41D7B038C9161EF167A1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAGeMpyYxfpEwpBcC4kAmEw== X-Mailru-Sender: 11C2EC085EDE56FAC71737E9F694C0DEB4105EDE4BEE9E46664D732D45546F217ACAAA8296ECBBDE645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/8] test: introduce LUAJIT_TEST_VARDIR variable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, On 31.08.2022 17:53, Igor Munkin wrote: > Sergey, > > Thanks for your review! > > On 15.08.22, Sergey Bronnikov wrote: >> Igor, >> >>  thanks for the patch. See my comments inline. >> >> On 11.08.2022 14:17, Igor Munkin wrote: >>> Before the patch both memprof and sysprof artefacts are generated within >>> the binary artefacts tree (i.e. in the same directory LuaJIT binary is >>> generated). However, more convenient way is producing these temporary >>> profiles in a separate directory (e.g. located on the partition with >>> more strict space limits). As a result of the patch all memprof and >>> sysprof test chunks consider LUAJIT_TEST_VARDIR environment variable to >>> set the directory where test profiles are generated. For the case when >>> LUAJIT_TEST_VARDIR is not set, everything works as before. >> Commit message is inconsistent a bit with a patch itself. >> >> As far as I understand many hunks are not related to introducing >> LUAJIT_TEST_VARDIR. >> >> Probably it is better to change commit one-line message from "test: >> introduce LUAJIT_TEST_VARDIR variable" >> >> to something like "test: refactoring and introduce LUAJIT_TEST_VARDIR >> variable". It allows to keep patch >> >> as is and change expectations for those who will look at your patch. > I believe your commit subject is too long, so I propose another > solution. Since the only thing affected by LUAJIT_TEST_VARDIR is > , so I can write something like "test: introduce > utils.profilename helper" and describe its rationale and functions > within the commit message. Are you OK with it? I'm ok!