From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 175642CC5F for ; Mon, 19 Nov 2018 08:48:01 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NtZRtu7L3iWa for ; Mon, 19 Nov 2018 08:48:01 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C668F2CC6A for ; Mon, 19 Nov 2018 08:48:00 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v1 07/10] sql: too many autogenerated ids leads to SEGFAULT References: <29812db7af2472398fd98f75c0daa811c8195ef6.1542460773.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: <27451ba2-4186-8fd3-cec9-8f62a94e88f3@tarantool.org> Date: Mon, 19 Nov 2018 16:47:58 +0300 MIME-Version: 1.0 In-Reply-To: <29812db7af2472398fd98f75c0daa811c8195ef6.1542460773.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Thanks for the patch! I have moved it into new patchset to make review easier. On 17/11/2018 17:04, imeevma@tarantool.org wrote: > This probleam appeared because region was cleaned twice: once in > sqlite3VdbeHalt() and once in sqlite3VdbeDelete() which was > executed during sqlite3_finalize(). Autogenerated ids that were > saved there, were fetched after sqlite3VdbeHalt() and before > sqlite3_finalize(). In this patch region cleaning in > sqlite3VdbeHalt() were removed. > > Needed for #3505 > Follow up #2618 > Follow up #3199 > --- > src/box/sql/vdbe.c | 8 ++------ > src/box/sql/vdbeaux.c | 6 ------ > test/sql/iproto.result | 16 ++++++++++++++++ > test/sql/iproto.test.lua | 7 +++++++ > 4 files changed, 25 insertions(+), 12 deletions(-) >