From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4D4E5E7F087; Fri, 20 Dec 2024 13:59:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D4E5E7F087 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734692357; bh=bA4+OZcJt/gQyuAzwPHPxp+XKomVPlzwgdA1Zx1UgTM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=FHQsvmhstbQTcGh3izU9ujDkzbmdB/LQtO3Q60HfWU9agML2CkJLSIn8ovAer/yDw /cFIUMLy0bJUmSqjk0l5KyWeS8kOktY8vOFa3bx3cbROJLwxPiYdRHw77KlQt5XmJB qvB9p82qmZmBssIyj/3zW13UrKNdpg9pTjILPB7A= Received: from send218.i.mail.ru (send218.i.mail.ru [95.163.59.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 58BD34BCFB7 for ; Fri, 20 Dec 2024 13:59:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 58BD34BCFB7 Received: by exim-smtp-cc4f974bf-x92tg with esmtpa (envelope-from ) id 1tOaiw-000000000mm-1Bpw; Fri, 20 Dec 2024 13:59:14 +0300 Content-Type: multipart/alternative; boundary="------------kwOyDzzu05yNoTjW89Kz9u0m" Message-ID: <2730f6cc-ed1e-415b-9871-e1ac10dcd9c3@tarantool.org> Date: Fri, 20 Dec 2024 13:59:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20241219093041.14681-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20241219093041.14681-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90D1D1AB5450899815CAE1582B24C296D611165901D3B4C36182A05F538085040AE3CBED69D91C81E3DE06ABAFEAF6705BC330F5270475493B7B52A90BE75C1789FE7245B80CF8774 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373768BF035B57E5168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84F4A6A4CE5630869DAF058DD7AAE514BA7D61781BCE6C864CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AF6136E347CC761E074AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3BFFF513DCDB8CC61BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B64854413538E1713F75ECD9A6C639B01B78DA827A17800CE79E6B27D82EEA174F731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5B804433F2B4696AB5002B1117B3ED696387C2C1C05B139E630E4A65F242F5898823CB91A9FED034534781492E4B8EEAD3CCD70CEBBF18A22BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3447DF5779098ECEE9FED5C8C220E441A5979D6377C74408234C6B1254768199045291500D14F085D21D7E09C32AA3244C56C0FC0A902EA8E877DD89D51EBB77425C333100BFE7C74BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfZ9BPZgVRhqT136JqrPhVw== X-Mailru-Sender: 0A26D9779F8DDEABFCA39D68568FDFDB75487293DE3AE594DF237C39DF1304747DC0CCE38225FFA28FB555F5A9668A00645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------kwOyDzzu05yNoTjW89Kz9u0m Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Sergey, thanks for the patch! See comments below. On 19.12.2024 12:30, Sergey Kaplun wrote: > The `strtod parsing` subtest in the checks > the results yielded by the `strtod()` via FFI call. In glibc versions > before 2.28 it returns an incorrect result (NaN instead of inf) for > "0x3p1023" [1]. This patch hardens the skipcond for this test for a > smaller version of the libc installed. > > [1]:https://sourceware.org/bugzilla/show_bug.cgi?id=23279 > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions > > The CI failure for libc 2.23 (ubuntu 16): > https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916 Ubuntu 16.04 EOL and EOS are reached [1] > The CI failure for libc 2.24 (debian 9): > https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859 Debian 9 EOL is reached 4 years ago [2] > The CI failure for libc 2.27 (ubuntu 18): > https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743 > The CI pass for libc 2.31 (ubuntu 20): > https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949 Ubuntu 20.04 support ends in 3 months and 2 week [1]. > > test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > index ac7d68a4..800c57b0 100644 > --- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua > +++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua > @@ -186,9 +186,11 @@ do --- tonumber parsing > test_conv(tonumber) > end > > --- Skip for the old libc version with the bug in the `strtod()`. > --- See alsohttps://sourceware.org/bugzilla/show_bug.cgi?id=16151. > -do --- strtod parsing -libc<2.19 > +-- Skip for the old libc version with the bugs in the `strtod()`. > +-- Affected versions: > +-- * <2.19:https://sourceware.org/bugzilla/show_bug.cgi?id=16151. > +-- * <2.28:https://sourceware.org/bugzilla/show_bug.cgi?id=23279. I propose to skip strtod test when Glibc is older than say 2.30 [3] and avoid testing with ancient Glibc versions because Glibc implementation is buggy [4] and a there are lot of bugs in old and more or less new versions: v2.41 [5], v2.22 [6], v2.27 [7], v2.15 [8], v2.33 [9] etc [10]. I don't think we should waste our time with issues like this. 1. https://endoflife.date/ubuntu 2. https://endoflife.date/debian 3. https://sourceware.org/glibc/wiki/Release 4. https://github.com/tarantool/luajit/blob/cd5ab5da9b56bf560407554c0377cfa8567d4430/src/lj_strscan.c#L20-L27 5. https://sourceware.org/bugzilla/show_bug.cgi?id=30220 6. https://sourceware.org/bugzilla/show_bug.cgi?id=19380 7. https://sourceware.org/bugzilla/show_bug.cgi?id=15744 8. https://sourceware.org/bugzilla/show_bug.cgi?id=14049 9. https://sourceware.org/bugzilla/show_bug.cgi?id=26137 10. https://sourceware.org/bugzilla/buglist.cgi?bug_status=__all__&content=strtod&no_redirect=1&order=bug_id%20DESC&product=glibc&query_format=specific > +do --- strtod parsing -libc<2.28 > test_conv(function(s) > local d = ffi.C.strtod(s, e) > return (e[0][0] == 0 and #s ~= 0) and d or nil --------------kwOyDzzu05yNoTjW89Kz9u0m Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hello, Sergey,

thanks for the patch! See comments below.


On 19.12.2024 12:30, Sergey Kaplun wrote:
The `strtod parsing` subtest in the <lib/base/tonumber_scan.lua> checks
the results yielded by the `strtod()` via FFI call. In glibc versions
before 2.28 it returns an incorrect result (NaN instead of inf) for
"0x3p1023" [1]. This patch hardens the skipcond for this test for a
smaller version of the libc installed.

[1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions

The CI failure for libc 2.23 (ubuntu 16):
https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916
Ubuntu 16.04 EOL and EOS are reached [1]
The CI failure for libc 2.24 (debian 9):
https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859
Debian 9 EOL is reached 4 years ago [2]
The CI failure for libc 2.27 (ubuntu 18):
https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743
The CI pass for libc 2.31 (ubuntu 20):
https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949
Ubuntu 20.04 support ends in 3 months and 2 week [1]. 



 test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua
index ac7d68a4..800c57b0 100644
--- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua
+++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua
@@ -186,9 +186,11 @@ do --- tonumber parsing
   test_conv(tonumber)
 end
 
--- Skip for the old libc version with the bug in the `strtod()`.
--- See also https://sourceware.org/bugzilla/show_bug.cgi?id=16151.
-do --- strtod parsing -libc<2.19
+-- Skip for the old libc version with the bugs in the `strtod()`.
+-- Affected versions:
+-- * <2.19: https://sourceware.org/bugzilla/show_bug.cgi?id=16151.
+-- * <2.28: https://sourceware.org/bugzilla/show_bug.cgi?id=23279.

I propose to skip strtod test when Glibc is older than say 2.30 [3] and avoid testing

with ancient Glibc versions because Glibc implementation is buggy [4] and

a there are lot of bugs in old and more or less new versions:

v2.41 [5], v2.22 [6], v2.27 [7], v2.15 [8], v2.33 [9] etc [10].


I don't think we should waste our time with issues like this.


1. https://endoflife.date/ubuntu

2. https://endoflife.date/debian

3. https://sourceware.org/glibc/wiki/Release

4. https://github.com/tarantool/luajit/blob/cd5ab5da9b56bf560407554c0377cfa8567d4430/src/lj_strscan.c#L20-L27

5. https://sourceware.org/bugzilla/show_bug.cgi?id=30220

6. https://sourceware.org/bugzilla/show_bug.cgi?id=19380

7. https://sourceware.org/bugzilla/show_bug.cgi?id=15744

8. https://sourceware.org/bugzilla/show_bug.cgi?id=14049

9. https://sourceware.org/bugzilla/show_bug.cgi?id=26137

10. https://sourceware.org/bugzilla/buglist.cgi?bug_status=__all__&content=strtod&no_redirect=1&order=bug_id%20DESC&product=glibc&query_format=specific

+do --- strtod parsing -libc<2.28
   test_conv(function(s)
     local d = ffi.C.strtod(s, e)
     return (e[0][0] == 0 and #s ~= 0) and d or nil
--------------kwOyDzzu05yNoTjW89Kz9u0m--